Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.4
    • Component/s: changes.xml
    • Labels:
      None
    • Environment:
      Maven version: 2.0.10
      Java version: 1.5.0_17
      OS name: "linux" version: "2.6.32-686" arch: "i386" Family: "unix"
    • Testcase included:
      yes
    • Number of attachments :
      5

      Description

      The fix for MCHANGES-189 does not seem to be correct. A changes.xml file containing HTML-Tags got rendered correctly using version 2.2. Starting with version 2.3, HTML-Tags will be encoded using HTML entities for the '<' and '>' characters leading to the actual tags getting shown in the report. See the attached example changes.xml file containing HTML no longer working with version 2.3.

      1. changes.xml
        0.5 kB
        Dennis Lundberg
      2. changes.xml
        0.7 kB
        Christian Schulte
      3. MCHANGES-190.patch
        3 kB
        Dennis Lundberg
      4. MCHANGES-190-2.patch
        3 kB
        Christian Schulte

        Issue Links

          Activity

          Hide
          Christian Schulte added a comment -

          Setting 'escapeHTML' to 'false' the patch works for me.

          Show
          Christian Schulte added a comment - Setting 'escapeHTML' to 'false' the patch works for me.
          Hide
          Christian Schulte added a comment -

          Although unrelated to this issue, looking at the announcement mail feature, I noticed that the 'announcement-generate' goal supports template encodings but the 'announcement-mail' goal does not. This patch adds a 'templateEncoding' parameter to the 'announcement-mail' goal.

          Show
          Christian Schulte added a comment - Although unrelated to this issue, looking at the announcement mail feature, I noticed that the 'announcement-generate' goal supports template encodings but the 'announcement-mail' goal does not. This patch adds a 'templateEncoding' parameter to the 'announcement-mail' goal.
          Hide
          Lukas Theussl added a comment -

          @Christian: If it's unrelated, please attach it to a new issue.

          @Dennis: as a hack, this is fine, I am just somewhat reluctant as introducing this means that we 'officially' support this feature, which was never the intention. Just making sure you are aware of the implications...

          Show
          Lukas Theussl added a comment - @Christian: If it's unrelated, please attach it to a new issue. @Dennis: as a hack, this is fine, I am just somewhat reluctant as introducing this means that we 'officially' support this feature, which was never the intention. Just making sure you are aware of the implications...
          Hide
          Dennis Lundberg added a comment -

          Right. Do you think I should add a disclaimer in the parameter documentation about this? Something like this:

          "Putting any kind of markup inside a CDATA section might mess up the Changes Report or other generated documents, such as PDFs, that are based on your changes.xml file."

          Show
          Dennis Lundberg added a comment - Right. Do you think I should add a disclaimer in the parameter documentation about this? Something like this: "Putting any kind of markup inside a CDATA section might mess up the Changes Report or other generated documents, such as PDFs, that are based on your changes.xml file."
          Hide
          Dennis Lundberg added a comment -

          Fixed in r1054123.

          Show
          Dennis Lundberg added a comment - Fixed in r1054123 .

            People

            • Assignee:
              Dennis Lundberg
              Reporter:
              Christian Schulte
            • Votes:
              8 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: