Maven Changes Plugin
  1. Maven Changes Plugin
  2. MCHANGES-143

Specifying sender email address using fromDeveloperId is no longer working.

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.2
    • Component/s: announcement
    • Labels:
      None
    • Environment:
      Maven 2.0.9, Windows XP Pro SP3.
    • Patch Submitted:
      Yes
    • Number of attachments :
      1

      Description

      According to the documentation and the available examples, it is possible specify the "from" address using either mailSend or fromDeveloperId. Starting with version 2.1, using fromDeveloperId leads to the following error:
      [INFO] Invalid mail sender: name and email is mandatory (null (null)).

      Looking at the source code, the regression seems to have been introduced by adding "@parameter expression="$

      {changes.mailSender}

      "" to the declaration of the mailSender attribute.

      Attached is a patch fixing the issue from the svn repository at revision 727375.

        Activity

        Hide
        Chad Gorshing added a comment -

        This may not be directly related to this issue, but according to the documentation at http://maven.apache.org/plugins/maven-changes-plugin/examples/specifying-mail-sender.html, it says "If no developer id is specified, the first <developer> in the list will be used."

        This is not happening on my machine (I'm sure I deserve http://www.codinghorror.com/blog/archives/000818.html). Would this issue be related to that or something entirely different?

        Show
        Chad Gorshing added a comment - This may not be directly related to this issue, but according to the documentation at http://maven.apache.org/plugins/maven-changes-plugin/examples/specifying-mail-sender.html , it says "If no developer id is specified, the first <developer> in the list will be used." This is not happening on my machine (I'm sure I deserve http://www.codinghorror.com/blog/archives/000818.html ). Would this issue be related to that or something entirely different?
        Hide
        Alexandre Navarro added a comment -

        I confirm, I have the same problem.
        In 2.0 it works
        In 2.1 I must set the
        <mailSender>
        <name>Alexandre Navarro</name>
        <email>alexandre.j.navarro@gmail.com</email>
        </mailSender>
        if I want to work.

        It is quite problematic when you use your plugin in enterprise.

        Show
        Alexandre Navarro added a comment - I confirm, I have the same problem. In 2.0 it works In 2.1 I must set the <mailSender> <name>Alexandre Navarro</name> <email>alexandre.j.navarro@gmail.com</email> </mailSender> if I want to work. It is quite problematic when you use your plugin in enterprise.
        Hide
        Alexandre Navarro added a comment -

        Can you integrate the patch?

        Show
        Alexandre Navarro added a comment - Can you integrate the patch?
        Hide
        Olivier Lamy added a comment -

        fixed in rev 769171
        Thanks !

        Show
        Olivier Lamy added a comment - fixed in rev 769171 Thanks !

          People

          • Assignee:
            Olivier Lamy
            Reporter:
            Christophe Labouisse
          • Votes:
            11 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: