Details

    • Type: New Feature New Feature
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.4
    • Component/s: announcement
    • Labels:
      None
    • Patch Submitted:
      Yes
    • Number of attachments :
      1

      Description

      I meant to submit this for inclusion in changes 2.1, but I guess I just missed it (2.1.1maybe?).

      We use the attached goal as part of release:prepare to ensure that the changes.xml has correct content before a release is done (changes:announcement-generate) is executed during release:perform.

      It really does two things:
      1) Ensures that the current version is represented in the changes.xml file (no special logic to do this, it's just in AnnouncementMjojo.getLatestRelease()).
      2) Ensures that the current version's release date isn't "TBD" or "tbd". This could be easily changed to be "in SVN" through configuration. If you want to make this the default and I'll add config to our organizational pom to use "tbd", fine with me.

      Since using this goal, we've eliminated a cause of release failures, so that's something...

        Issue Links

          Activity

          Hide
          Dennis Lundberg added a comment -

          I like this, it adds one more level of checking of the changes.xml file on top of what "changes-validate" already does.

          I would prefer to call the goal "changes-check" instead, because the "announcement-generate" goal works with more than just changes.xml files. It can fetch releases from JIRA as well.

          What do you think Justin?

          Show
          Dennis Lundberg added a comment - I like this, it adds one more level of checking of the changes.xml file on top of what "changes-validate" already does. I would prefer to call the goal "changes-check" instead, because the "announcement-generate" goal works with more than just changes.xml files. It can fetch releases from JIRA as well. What do you think Justin?
          Hide
          Dennis Lundberg added a comment -

          I modified the original patch to use a date format instead of a special token to recognize an invalid release date. A test case and documentation was also added.

          Fixed in r1050224. 2.4-SNAPSHOT deployed.

          Thanks!

          Show
          Dennis Lundberg added a comment - I modified the original patch to use a date format instead of a special token to recognize an invalid release date. A test case and documentation was also added. Fixed in r1050224 . 2.4-SNAPSHOT deployed. Thanks!

            People

            • Assignee:
              Dennis Lundberg
              Reporter:
              Justin Edelson
            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: