Maven Changelog Plugin
  1. Maven Changelog Plugin
  2. MCHANGELOG-74

Combined patch for MCHANGELOG-69, MCHANGELOG-70, MCHANGELOG-71, MCHANGELOG-72, MCHANGELOG-73

    Details

    • Type: Task Task
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 2.1
    • Fix Version/s: None
    • Labels:
      None
    • Patch Submitted:
      Yes
    • Number of attachments :
      3

      Description

      This is a combined patch for MCHANGELOG-69, MCHANGELOG-70, MCHANGELOG-71, MCHANGELOG-72, MCHANGELOG-73. I have produced individual patches for each issue so that the code can easily be reviewed by the committers and then this combined patch to allow all those mini-patches to be easily applied against the trunk.

      I hope this is considered ok as I could not think of a better way to make the job of the committer easy, plus it was right pain to do

      All updates made against trunk revision 560535.

      Note there are two change in this combined patch to the individual patches - due to MCHANGELOG-68 I had switched on ignore test failures - and being an idiot had not kept track of how many unit tests were failing. To my horror I noticed that loads of the tests were failing but not due to functional issues as such but instead due to the NPEs being raised because a lack of injected values. I have since changed the code to, where appropriate, check for nulls and thus all the unit tests NPEs have gone away. Sorry I should have had my eye on this right from the start.

      1. MCHANGELOG-69,70,71,72,73.patch
        16 kB
        John Allen
      2. MCHANGELOG-69,70,71,72,73.patch
        16 kB
        John Allen
      3. MCHANGELOG-69,70,71,72,73.patch
        17 kB
        John Allen

        Activity

        Hide
        John Allen added a comment -

        removed unnecessary change to ChangeLogReportTest

        Show
        John Allen added a comment - removed unnecessary change to ChangeLogReportTest
        Hide
        John Allen added a comment -

        previous patch was missing a call to sinkAuthorNames() in doChangeSetDetails() methods and thus did not print active links for the developer names (was a patch error)

        Show
        John Allen added a comment - previous patch was missing a call to sinkAuthorNames() in doChangeSetDetails() methods and thus did not print active links for the developer names (was a patch error)
        Hide
        Dennis Lundberg added a comment -

        I applied the individual patches instead.

        Show
        Dennis Lundberg added a comment - I applied the individual patches instead.

          People

          • Assignee:
            Unassigned
            Reporter:
            John Allen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: