Maven Changelog Plugin
  1. Maven Changelog Plugin
  2. MCHANGELOG-3

Links in File Activity Report can be wrong when using subversion, after a copy command has been issued

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0
    • Labels:
      None
    • Environment:
      OSX 10.4.3, java 1.4.2_09
    • Number of attachments :
      5

      Description

      When you do a subversion copy command, the list of files produced by svn log often have additional information that is part of the filename:

      R /tags/prt-1.3/prt-admin/pom.xml (from /trunk/prt-admin/pom.xml:128)

      In SvnChangeLogParser.java, the file name is parsed as /tags/prt-1.3/prt-admin/pom.xml (from /trunk/prt-admin/pom.xml:128) when of course it should be /tags/prt-1.3/prt-admin/pom.xml. This is most significantly manifested when a link is generated, such as in the File Activity Report.

      http://...?repname=prt&sc=0&path=/tags/prt-1.3/pom.xml%20(from%20/trunk/pom.xml:128)

      I can see two approaches to the problem. The simplest is to add a regular expression which deletes the extraneous data, but then you lose that potentially valuable information. Maybe ChangeLogFile should keep track of a file (path) and a name, rather than just a name, so that the link can be made properly.

      1. changelog.xml
        2 kB
        Julian Wood
      2. MCHANGELOG-3.patch
        5 kB
        Julian Wood
      3. MOJO-216-changelog-maven-plugin.patch
        0.9 kB
        Julian Wood
      4. MOJO-216-changelog-maven-plugin-1a.patch
        4 kB
        Julian Wood
      5. svnlog2.txt
        6 kB
        Julian Wood

        Activity

        Show
        Julian Wood added a comment - Found it. http://svn.apache.org/viewcvs.cgi/maven/sandbox/plugins/ J
        Hide
        Edwin Punzalan added a comment -

        Julian, how's this issue?

        Show
        Edwin Punzalan added a comment - Julian, how's this issue?
        Hide
        Julian Wood added a comment -

        Still there AFAIK. Check out:

        http://commons.ucalgary.ca/projects/lc-webapp-archetype/changelog.html

        and look at some of the links like:

        /trunk/pom.xml (from /pom.xml:8)

        Let me check if the patch still works.

        J

        Show
        Julian Wood added a comment - Still there AFAIK. Check out: http://commons.ucalgary.ca/projects/lc-webapp-archetype/changelog.html and look at some of the links like: /trunk/pom.xml (from /pom.xml:8) Let me check if the patch still works. J
        Hide
        Julian Wood added a comment -

        Okay obviously those files and patches don't work any more - I can't delete them though. Here's a new patch, MCHANGELOG-3.patch, which fixes the problem. It does 3 things:

        1. Change line-endings to \n from \r\n in min-changelog.xml so that patch command can work.
        2. Add the problematic file/name text content to one of the file/name elements.
        3. Fix the problem in ChangeLogHandler.java by using a regex to filter out the problematic name.

        Note that there is a potential conflict with MCHANGELOG-36a.patch, since they both alter ChangeLogHandler.java. If this patch is applied first, it will be okay.

        Show
        Julian Wood added a comment - Okay obviously those files and patches don't work any more - I can't delete them though. Here's a new patch, MCHANGELOG-3 .patch, which fixes the problem. It does 3 things: 1. Change line-endings to \n from \r\n in min-changelog.xml so that patch command can work. 2. Add the problematic file/name text content to one of the file/name elements. 3. Fix the problem in ChangeLogHandler.java by using a regex to filter out the problematic name. Note that there is a potential conflict with MCHANGELOG-36 a.patch, since they both alter ChangeLogHandler.java. If this patch is applied first, it will be okay.
        Hide
        Edwin Punzalan added a comment -

        Patch applied, thanks.

        Show
        Edwin Punzalan added a comment - Patch applied, thanks.

          People

          • Assignee:
            Edwin Punzalan
            Reporter:
            Julian Wood
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: