Maven 2.x Castor Plugin

Maven 2 castor plugin

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Testcase included:
    yes
  • Number of attachments :
    1

Description

Hi. I created a Maven 2 version of the castor plugin. Hope you can check it out. Thanks.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Brett Porter added a comment -

feel free to commit this. We can review from there. Also, please don't use .rar, it's very uncommon to be installed. tar.gz or tar.bz2 o even .zip are better.

feedback no the POM:

  • please inherit the mojo parent and remove an elements you inherit from there
  • please remove the license section - it is incorrect (and should be inherited anyway)
  • please remove the test source directory (that's the default anyway)
  • please set the version to 1.0-SNAPSHOT until it is properly released

Feedback on the code:

  • I don't understand the expressions you have. castor is not the right base directory to use, and non-expressions should be in default-value
  • boolean types should use boolean, not String to make the code cleaner
  • please use the Maven code formatting
  • please avoid catching Exception
  • please don't print stack traces - throw them wrapped in a MojoExecutionException
Show
Brett Porter added a comment - feel free to commit this. We can review from there. Also, please don't use .rar, it's very uncommon to be installed. tar.gz or tar.bz2 o even .zip are better. feedback no the POM: please inherit the mojo parent and remove an elements you inherit from there please remove the license section - it is incorrect (and should be inherited anyway) please remove the test source directory (that's the default anyway) please set the version to 1.0-SNAPSHOT until it is properly released Feedback on the code: I don't understand the expressions you have. castor is not the right base directory to use, and non-expressions should be in default-value boolean types should use boolean, not String to make the code cleaner please use the Maven code formatting please avoid catching Exception please don't print stack traces - throw them wrapped in a MojoExecutionException
Hide
Permalink
Brett Porter added a comment -

you also shouldn't need the filesystem tool - you can get this from FileUtils in commons-io

Show
Brett Porter added a comment - you also shouldn't need the filesystem tool - you can get this from FileUtils in commons-io
Hide
Permalink
John Tolentino added a comment -

Updated code to address all issues identified.

Show
John Tolentino added a comment - Updated code to address all issues identified.
John Tolentino made changes -
Field Original Value New Value
Attachment maven-castor-plugin.zip [ 16413 ]
Hide
Permalink
Brett Porter added a comment -

Thanks John - please work with someone who is online at the time to help you get into your account to check this in (trygvis and dblevins can both help I think)

Show
Brett Porter added a comment - Thanks John - please work with someone who is online at the time to help you get into your account to check this in (trygvis and dblevins can both help I think)
Brett Porter made changes -
Component/s sandbox [ 11747 ]
Component/s castor [ 11818 ]
Brett Porter made changes -
Status Open [ 1 ] Closed [ 6 ]
Assignee John Tolentino [ jtolentino ]
Resolution Fixed [ 1 ]
Brett Porter made changes -
Workflow Maven [ 38788 ] Maven New [ 50020 ]
Brett Porter made changes -
Project Mojo [ 11062 ] Maven 2.x Castor Plugin [ 11191 ]
Key MOJO-6 MCASTOR-7
Component/s castor [ 11818 ]

People

  • Assignee:
    John Tolentino
    Reporter:
    John Tolentino
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: