Castor generates code which doesn't compile

Can I please ask you to raise this as a problem over at the CASTOR project, as it seems to be a genuine problem of code generation related to one specific version of Castor ?

You can ask, but my problem is with castor-maven-plugin.

If I did what you asked, I would have to raise my issue at the CASTOR project (and then perhaps at subproject X, Y, Z, ...). Afterwards, I have to ask if this project is willing to use the most recent version of castor (although I can introduce it as a dependency to the plugin).

Is it not possible in jira to just pass my request to the castor project? I can imagine that this issue is then put ON HOLD until fixes are made in the castor project. And when that happens the status of this issue will turn into OPEN again.

I can imagine that my request at the castor project will be turned down, because I'm using version 1.3.1 of castor-codegen (through castor-maven-plugin).

BTW. castor-maven-plugin:2.1 does not use the most recent version of castor-codegen (i.e. 1.3.2). Indeed, they are incompatible as

<plugin>
...
<artifactId>castor-maven-plugin</artifactId>
<version>2.1</version>
...
<dependencies>
<dependency>
<groupId>org.codehaus.castor</groupId>
<artifactId>castor-codegen</artifactId>
<version>1.3.2</version>
</dependency>
</dependencies>
</plugin>

fails:

[ERROR] Failed to execute goal org.codehaus.mojo:castor-maven-plugin:2.1:generat
e (default) on project DocumentationSupport: Castor execution failed: org.exolab
.castor.xml.schema.Schema.getImportedSchema()Ljava/util/Collection; -> [Help 1]

Furthermore:

<plugin>
...
<artifactId>castor-maven-plugin</artifactId>
<version>2.0</version>
...
<dependencies>
<dependency>
<groupId>org.codehaus.castor</groupId>
<artifactId>castor-codegen</artifactId>
<version>1.3.2</version>
</dependency>
</dependencies>

succeeds, so there seems some regression has occurred in castor-maven-plugin:2.1.

Can we first try to solve this problem by introducing castor-codegen:1.3.2 as a dependency of castor-maven-plugin?

Can we first try to solve this problem by introducing castor-codegen:1.3.2 as a dependency of castor-maven-plugin?

If there's a regression issue with regards to the castor-maven-plugin, I will look into this in the context of this plugin.

Don't worry too much about all the other questions: if the issue is a problem with Castor (and still is a valid issue with release 1.3.2), we'll have a look. And if you really require a solution fast, and are not in a position to wait for a Castor 1.3.3 release, we can always push a snapshot release of Castor 1.3.3 to a Maven repo (for you to pick up).

But please do understand my request re: the separation of concerns as well.

First finding: can you please change dependency override section of your <plugin> definition as follows:

<dependencies>
   <dependency>
      <groupId>org.codehaus.castor</groupId>
      <artifactId>castor-codegen</artifactId>
      <version>1.3.2</version>
   </dependency>
   <dependency>
      <groupId>org.codehaus.castor</groupId>
      <artifactId>castor-xml-schema</artifactId>
      <version>1.3.2</version>
   </dependency>
</dependencies>

That should get you goinga against Castor 1.3.2, whilst I look into this dependency resolution problem.

In addition, found the problem related to the static initializer code; if you kindly raised a Castor Jira, I am in a position to provide and commit a patch.

Adding castor-xml-schema:1.3.2 as a dependency does help.

However, both castor-maven-plugin:2.0 and castor-maven-plugin:2.1 generate erroneous code. I will raise an issue at CASTOR.

Fixing this within the Castor project, and making this available through a new release of this plugin.