Maven 1

Generated html-colored java source is not valid HTML - fails in Opera 6

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.0-beta-10, 1.0-rc1
  • Fix Version/s: 1.0-rc2
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    3

Description

some plugin generates colored html source, here's a sample,

http://cglib.sourceforge.net/xref/samples/Trace.html

unfotunantly a table is put inside a pre which is as far as I reacall not valid HTML 4.0

in opera 6 this results in horrible viewing experience - pre is ignored

yes, btw, the center tag is also either deprecated or absent in HTML 4.0 - better use css text-align: center, but this does not cause a rendering catastrophe in opera 6.

additionally, it would be best to have a html 4.01 or xhtml 1.0 DOCTYPE (potentially this enforces same behavior on all browsers and disables quirks and compat modes)

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
dion gillard added a comment -

No patch, moving to 1.1

Show
dion gillard added a comment - No patch, moving to 1.1
Hide
Permalink
fabrizio giustina added a comment -

the attached patch makes the jxr plugin generate valid xhtml code.

This fixes all the jsl files, the css stylesheet, and the CodeTransform class.
Code generated by CodeTransform is now validated against the XHTML 1.0 dtd. All the deprecated elements are removed (no more <font> or <center> tags) and color highlight is controlled by css.
Changes in the CodeTransform.class include some clean up and javadocs improvement, other than fixes in the generated code (removed table inside a <pre>, filtered & and not >)

The patch has been tested with different project and the generated code is fully validating. Please consider adding this patch before 1.0-rc2 release

Show
fabrizio giustina added a comment - the attached patch makes the jxr plugin generate valid xhtml code. This fixes all the jsl files, the css stylesheet, and the CodeTransform class. Code generated by CodeTransform is now validated against the XHTML 1.0 dtd. All the deprecated elements are removed (no more <font> or <center> tags) and color highlight is controlled by css. Changes in the CodeTransform.class include some clean up and javadocs improvement, other than fixes in the generated code (removed table inside a <pre>, filtered & and not >) The patch has been tested with different project and the generated code is fully validating. Please consider adding this patch before 1.0-rc2 release
Hide
Permalink
dion gillard added a comment -

The patch fails to apply on CodeTransform.java.

Could you please recreate it?

Thanks!

Show
dion gillard added a comment - The patch fails to apply on CodeTransform.java. Could you please recreate it? Thanks!
Hide
Permalink
fabrizio giustina added a comment -

ok, I'm attaching a patch recreated against the latest cvs version

Show
fabrizio giustina added a comment - ok, I'm attaching a patch recreated against the latest cvs version
Hide
Permalink
dion gillard added a comment -

Still no luck applying the codetransform patch. How come it is a replacement of the whole file?

Show
dion gillard added a comment - Still no luck applying the codetransform patch. How come it is a replacement of the whole file?
Hide
Permalink
fabrizio giustina added a comment -

I'm attaching the full source for all the modified files, you should be able to merge changes to CodeTransform using CVS. See my initial comment about changes in CodeTransform.java.

You can see a sample of jxr docs generated using the patched version at http://displaytag.sourceforge.net/xref/index.html

Show
fabrizio giustina added a comment - I'm attaching the full source for all the modified files, you should be able to merge changes to CodeTransform using CVS. See my initial comment about changes in CodeTransform.java. You can see a sample of jxr docs generated using the patched version at http://displaytag.sourceforge.net/xref/index.html
Hide
Permalink
dion gillard added a comment -

Applied to jxr 1.3-SNAPSHOT.
Thanks!

Show
dion gillard added a comment - Applied to jxr 1.3-SNAPSHOT. Thanks!

People

  • Assignee:
    Unassigned
    Reporter:
    Anton Tagunov
Vote (1)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: