Details

    • Type: New Feature New Feature
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: model additions
    • Labels:
      None
    • Number of attachments :
      0

      Description

      Something discussed on the dev/user lists recently, and an initial implementation is in place. Here is my proposal from the list:

      I would like to propose a generic solution via the POM and whatever filter-enabled copying technique that is being used. Let me know what you think.

      Firstly, inside <build>:
      <filters>
      <file>$

      {basedir}/conf/${maven.username}.properties</file>
      <file>${basedir}

      /conf/filters.properties</file>
      <file>$

      {basedir}

      /../common/filters.properties</file>
      <filter>
      <token>some.property</token>
      <value>some.value</value>
      </filter>
      </filters>

      Or to go really crazy, have the above as a filterset, and wrap them up in a list of filtersets. Ant introduced this functionality, but personally I don't see the use for it as long as you keep your property names a little different.

      I also think build.properties, project.properties and driver/default.properties should be included by default when filtering is enabled.

      Now, each <resource/> element can keep the <filtering>true</filtering> property to acknowledge it wants to be filtered.

      The reason to allow different files is that the purpose of filters is to be able to substitute varying values, so you may not want to hard code them into project.xml. And this configuration should be flexible enough to work without Ant if necessary.


      I'm happy to work on this once there is agreement - just opening this to track its progress.

        Issue Links

          Activity

          Hide
          Brett Porter added a comment -

          alternative proposed for m2, but relies on decent profile support which Maven1 won't have.

          Show
          Brett Porter added a comment - alternative proposed for m2, but relies on decent profile support which Maven1 won't have.
          Hide
          Brett Porter added a comment -

          we can reuse the m2 solution, I got carried away

          Show
          Brett Porter added a comment - we can reuse the m2 solution, I got carried away
          Hide
          Michael Osipov added a comment -

          Please refer to https://cwiki.apache.org/confluence/display/MAVEN/The+Great+JIRA+Cleanup+of+2014 if you're wondering why this issue was closed out.

          Show
          Michael Osipov added a comment - Please refer to https://cwiki.apache.org/confluence/display/MAVEN/The+Great+JIRA+Cleanup+of+2014 if you're wondering why this issue was closed out.

            People

            • Assignee:
              Unassigned
              Reporter:
              Brett Porter
            • Votes:
              5 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: