Maven 1

Importing a jelly script used to expose goals definied in it.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: 1.0-beta-8
  • Fix Version/s: 1.0-rc3
  • Component/s: jelly/ant integration
  • Labels:
    None
  • Environment:
    W2k with CVS Head
  • Number of attachments :
    0

Description

Previously, you could import a jelly script and expose the goals. This was crucially import in the cactus plugin for dynamically importing the scripts for various app servers. At this point, this functionality doesn't work. Should I edit the touchstone code to demonstrate this?

Here is what used to work:
<!-- Import all the jelly scripts found in the maven.cactus.conf.dir
directory. They are jelly scripts to start/stop the different
containers. -->
<fileScanner var="scanner">
<fileset dir="$

{maven.cactus.scripts.dir}

" includes="*.jelly"/>
</fileScanner>

<j:forEach var="script" items="$

{scanner.iterator()}

">
<j:import inherit="true" uri="$

{script.toURL().toString()}

"/>
</j:forEach>

if you do a maven -g you will see all the included file's goals are not available.

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. MAVEN-1161 goal mapper does not follow j:import tags

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
David Eric Pugh added a comment -

I think this same problem afflicts the j2ee plugin.

This line here doesn't seem to actually work.
<j:import inherit="true" uri="./appserver/tomcat-4.x.jelly" />

Show
David Eric Pugh added a comment - I think this same problem afflicts the j2ee plugin. This line here doesn't seem to actually work. <j:import inherit="true" uri="./appserver/tomcat-4.x.jelly" />
Hide
Permalink
David Eric Pugh added a comment -

I did figure out that you can call the targets from your Jelly script for imported .jelly files, just not call them from the command line.

Show
David Eric Pugh added a comment - I did figure out that you can call the targets from your Jelly script for imported .jelly files, just not call them from the command line.
Hide
Permalink
dion gillard added a comment -

This is because the plugin cache manager parses files before they are loaded and doesn't parse the <include>'d files.

I doubt this will change for 1.0.

Show
dion gillard added a comment - This is because the plugin cache manager parses files before they are loaded and doesn't parse the <include>'d files. I doubt this will change for 1.0.
Hide
Permalink
Brett Porter added a comment -

won't fix, see Maven-1161 for reason

Show
Brett Porter added a comment - won't fix, see Maven-1161 for reason

People

  • Assignee:
    Unassigned
    Reporter:
    David Eric Pugh
Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: