jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • Maven 1
  • MAVEN-195

Artifact enhancement - add method getArtifactSubDirectory()

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.0-beta-8
  • Fix Version/s: 1.0-rc1
  • Component/s: None
  • Labels:
    None

Description

I think that it will be nice to have single place in GenericArtifact class
which hided strategy how the directory where artifact file is kept
is named.

Currently the strategy to name this directory is:

getDependency().getType() + "s"

My proposition is to have:

/**

  • Get the directory to place the artifact in
    *
  • @return The artifact sub directory.
    */
    public String getArtifactSubDirectory() { // simple version. Later this can be made more // complicated by providing more adavanced ArtifactFactoryClasse(s) // but the staregy will be hidden grace to this method return getType()+"s"; }

This will result in possiblity of rewriting methods like getUrlPath in following way:

/** @see Artifact#getUrlPath */
public String getUrlPath()

{ return "/" + getDependency().getArtifactDirectory() + "/" + getArtifactSubDirectory() + "/" + getDependency().getArtifact(); }

Activity

Ascending order - Click to sort in descending order
  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
Michal Maczka added a comment - 05/Aug/03 2:29 PM

We don't need it any more.
${artifact.parent.parent} does a trick

Show
Michal Maczka added a comment - 05/Aug/03 2:29 PM We don't need it any more. ${artifact.parent.parent} does a trick
Hide
Permalink
Arnaud Heritier added a comment - 27/Oct/05 4:14 PM

Fixed a long long time ago !!

Show
Arnaud Heritier added a comment - 27/Oct/05 4:14 PM Fixed a long long time ago !!

People

  • Assignee:
    Jason van Zyl
    Reporter:
    Michal Maczka
Vote (0)
Watch (0)

Dates

  • Created:
    12/Jan/03 11:28 AM
    Updated:
    08/Mar/06 10:47 PM
    Resolved:
    05/Aug/03 2:29 PM
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.