Details
-
Type:
Improvement
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.1-beta-2
-
Fix Version/s: 1.1-rc1
-
Component/s: None
-
Labels:None
-
Environment:OS windows xp, JVM sun 1.4.2
-
Number of attachments :
Description
The Goal.checkForCycle method is a hotspot as the reactor starts.
Most of the time is spent in creating HashSets and filling them (see attached screen shot).
Instead of creating a new HasSet each time, reusing the same improves the performance of dependency analysis (see attached file Goal.java).
Due to security policy in my company I can't checkout the sources and run non-regression tests, at least it works fine on our project.
It's working fine. Your algorithm is better and allow us to not create a new instance each time in the loop.