Maven 1

Performance Optimization of the Reactor

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.1-beta-2
  • Fix Version/s: 1.1-rc1
  • Component/s: None
  • Labels:
    None
  • Environment:
    OS windows xp, JVM sun 1.4.2
  • Number of attachments :
    2

Description

The Goal.checkForCycle method is a hotspot as the reactor starts.
Most of the time is spent in creating HashSets and filling them (see attached screen shot).

Instead of creating a new HasSet each time, reusing the same improves the performance of dependency analysis (see attached file Goal.java).

Due to security policy in my company I can't checkout the sources and run non-regression tests, at least it works fine on our project.

  1. Java Source File
    Goal.java
    31/Aug/06 3:49 AM
    24 kB
    Emmanuel Renaud
  1. reactor-jprofiler.GIF
    48 kB
    31/Aug/06 3:49 AM

Activity

Hide
Permalink
Arnaud Heritier added a comment -

It's working fine. Your algorithm is better and allow us to not create a new instance each time in the loop.

Show
Arnaud Heritier added a comment - It's working fine. Your algorithm is better and allow us to not create a new instance each time in the loop.

People

  • Assignee:
    Arnaud Heritier
    Reporter:
    Emmanuel Renaud
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: