Maven 1

org.apache.maven.MavenUtils.loadProperties(..) does not close the FileInputStream (relying upon finalization)

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.1-beta-2
  • Fix Version/s: 1.1-beta-3
  • Component/s: core
  • Labels:
    None
  • Number of attachments :
    2

Description

org.apache.maven.MavenUtils.loadProperties(..) does not close the FileInputStream (relying upon finalization)

See attached patch.

  1. Text File
    JellyScriptHousing.patch
    16/May/06 8:54 AM
    2 kB
    John Sisson
  2. Text File
    MavenUtils.patch
    16/May/06 8:44 AM
    2 kB
    John Sisson

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. MAVEN-1733 Bootstrap failure: Unable to delete directory ...

  • Major - Major loss of function.
  • Reopened - This issue was once resolved, but the resolution was deemed incorrect. From here issues are either marked assigned or resolved.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
John Sisson added a comment -

Also have patch for JellyScriptHousing that ensures close() is called in a finally block.

Show
John Sisson added a comment - Also have patch for JellyScriptHousing that ensures close() is called in a finally block.
Hide
Permalink
John Sisson added a comment -

Also in MavenUtils, the getNonJellyProject(..) method does not close the FileReader that is created.

Show
John Sisson added a comment - Also in MavenUtils, the getNonJellyProject(..) method does not close the FileReader that is created.
Hide
Permalink
John Sisson added a comment -

Similar problems with the compileScript and runScript methods in JellyUtils.java where a FileInputStream is not closed.

Show
John Sisson added a comment - Similar problems with the compileScript and runScript methods in JellyUtils.java where a FileInputStream is not closed.
Hide
Permalink
Arnaud Heritier added a comment -

I checked that we close all the InputStreams we open.

Show
Arnaud Heritier added a comment - I checked that we close all the InputStreams we open.

People

  • Assignee:
    Arnaud Heritier
    Reporter:
    John Sisson
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: