Maven 1

Don't try to download SNAPSHOTs built in the same build

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 1.1-beta-2
  • Fix Version/s: None
  • Component/s: core
  • Labels:
    None
  • Number of attachments :
    0

Description

The Geronimo build includes like 50 modules. During normal development, these are SHAPSHOTs. As of Maven 1.1-beta2, each SNAPSHOT is downloaded at most once during the build, which cut down on a lot of extraneous downloads (that is, say 40 of the 50 modules depend on geronimo-kernel, Maven will only check to download it once).

However, since the geronimo build actually builds geronimo-kernel, there's no need to check to download it at all. It would be great if, as a module is built, if that module is a SNAPSHOT, it would be added to the "previously checked snapshots" list, so no subsequent modules that depends on it would attempt to download it at all. That would eliminate nearly all the download activity during the Geronimo build, making it substantially faster.

Thanks.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Aaron Mulder added a comment -

Oh, you're killing me!

I was really hoping this would turn out to be a trivial fix (as module is built, add to "already downloaded" list). This would seriously speed up online Geronimo builds by like 95% since it has to download on the order of 50 modules during a full build, and there are few if any SNAPSHOTs outside of Geronimo itself.

Is there any way this could be squeeze into 1.1-beta-3?

Thanks,
Aaron

Show
Aaron Mulder added a comment - Oh, you're killing me! I was really hoping this would turn out to be a trivial fix (as module is built, add to "already downloaded" list). This would seriously speed up online Geronimo builds by like 95% since it has to download on the order of 50 modules during a full build, and there are few if any SNAPSHOTs outside of Geronimo itself. Is there any way this could be squeeze into 1.1-beta-3? Thanks, Aaron
Hide
Permalink
Lukas Theussl added a comment -

Sure, got a patch?

Show
Lukas Theussl added a comment - Sure, got a patch?
Hide
Permalink
Aaron Mulder added a comment -

Can you point me to the parts of the 1.1 code where "module build is finished" and "maintain list of previously attempted downloads" happen? I'm completely unfamiliar with the Maven code. Thanks.

Show
Aaron Mulder added a comment - Can you point me to the parts of the 1.1 code where "module build is finished" and "maintain list of previously attempted downloads" happen? I'm completely unfamiliar with the Maven code. Thanks.
Hide
Permalink
Lukas Theussl added a comment -

So am I...

That's really the problem we are having in maven 1 now: all the people who are actually familiar with the code are not interested in it anymore...

Show
Lukas Theussl added a comment - So am I... That's really the problem we are having in maven 1 now: all the people who are actually familiar with the code are not interested in it anymore...
Hide
Permalink
Brett Porter added a comment -

the m1 codebase isn't really that big, and if you stay away from the jelly and plugin manager monstrosity, pretty easy to understand.

For this, I'd suggest ReactorTag should call a static method on DependencyVerifier to set the resolved ids after getting the list of sorted projects.

Show
Brett Porter added a comment - the m1 codebase isn't really that big, and if you stay away from the jelly and plugin manager monstrosity, pretty easy to understand. For this, I'd suggest ReactorTag should call a static method on DependencyVerifier to set the resolved ids after getting the list of sorted projects.

People

  • Assignee:
    Unassigned
    Reporter:
    Aaron Mulder
Vote (0)
Watch (0)

Dates

  • Created:
    Updated: