Maven 1

Variable scope problem

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 1.1-beta-2
  • Fix Version/s: 1.1-beta-3
  • Component/s: jelly/ant integration
  • Labels:
    None
  • Testcase included:
    yes
  • Number of attachments :
    1

Description

There's a bug in m1.1 that doesn't exist in m1.0.X
When you define a variable in a custom goal for a project, this last one is available for others projects.
It cause a problem for example if you use several multiproject:goal.
We have this problem in maven-plugins when we launch the goal plugins:test-all
If a plugin use the multiproject with a new goal (<j:set:var="goal" ...), than the reactor use this goal for all plugins after it.
I attached a test case for the multiproject plugin. It works with maven 1.0.2 but not with maven 1.1-beta2.

Issue Links

This issue is related to:
MPMULTIPROJECT-49 Can not mix multiproject goals with other/custom goals Major Closed
This issue is depended upon by:
MPMULTIPROJECT-60 goal in multiproject:goal isn't correctly called if the tag is used several times in a build with different goals Blocker Closed
MAVEN-1638 Post goals in plugins only seem to run once Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Brett Porter added a comment -

this is probably related to Jelly 1.0's change in tag caching.

Show
Brett Porter added a comment - this is probably related to Jelly 1.0's change in tag caching.
Hide
Permalink
Arnaud Heritier added a comment -

ok, i'll try to investigate and if possible/needed I'll propose a patch for Jelly.

Show
Arnaud Heritier added a comment - ok, i'll try to investigate and if possible/needed I'll propose a patch for Jelly.
Hide
Permalink
Lukas Theussl added a comment -

It is indeed a bug in jelly and it has already been fixed in svn: http://svn.apache.org/viewcvs.cgi?rev=227285&view=rev

Unfortunately, with the current jelly 1.1-SNAPSHOT, I see a whole bunch of other test failures in our plugins, but at least your attached test case works!

Show
Lukas Theussl added a comment - It is indeed a bug in jelly and it has already been fixed in svn: http://svn.apache.org/viewcvs.cgi?rev=227285&view=rev Unfortunately, with the current jelly 1.1-SNAPSHOT, I see a whole bunch of other test failures in our plugins, but at least your attached test case works!
Hide
Permalink
Arnaud Heritier added a comment -

good. We have to ask them to release a new version ASAP.

Show
Arnaud Heritier added a comment - good. We have to ask them to release a new version ASAP.
Hide
Permalink
Lukas Theussl added a comment -

For the record: the above mentioned test failures are due to another blocking issue that has been introduced since in jelly: http://issues.apache.org/jira/browse/JELLY-230

I'm waiting for Paul to come up with a solution...

Show
Lukas Theussl added a comment - For the record: the above mentioned test failures are due to another blocking issue that has been introduced since in jelly: http://issues.apache.org/jira/browse/JELLY-230 I'm waiting for Paul to come up with a solution...
Hide
Permalink
Lukas Theussl added a comment -

Upgraded to our own jelly version (see MAVENUPLOAD-998).

Show
Lukas Theussl added a comment - Upgraded to our own jelly version (see MAVENUPLOAD-998).

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.