[#MAVEN-1511] Jar override does not work when trying to override to SNAPSHOT - jira.codehaus.org

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 1.0, 1.0.1
Fix Version/s: 1.0.2
Component/s: model
Labels:
None
Environment:
All

Number of attachments :
0

Description

The code in ArtifactListBuilder that checks the type of override being performed (version or path) just checks that the value of the first character of mavenJarProperty is a digit. If you are tyring to override to SNAPSHOT this doesn't work. If the code was changed from

if ( mavenJarOverride && StringUtils.isNotEmpty(mavenJarProperty) )

if ( mavenJarOverride && (StringUtils.isNotEmpty(mavenJarProperty) ||
"SNAPSHOT".equals(mavenJarProperty)))

then we'd be able to override to SNAPSHOT for integration builds and not have to change all the dependencies before a relase (and then back to SNAPSHOT after).

Issue Links

This issue is related to:
MAVEN-1821	Jar override doesn't work when using a named-version

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Jon Strayer added a comment - 19/Nov/04 4:32 PM

Damn, I hosed the code. It should be changes from this:

if ( Character.isDigit( mavenJarProperty.charAt( 0 ) ) )

to this:

if ( Character.isDigit( mavenJarProperty.charAt( 0 ) ) || "SNAPSHOT".equals(mavenJarProperty) )

Show

Jon Strayer added a comment - 19/Nov/04 4:32 PM Damn, I hosed the code. It should be changes from this: if ( Character.isDigit( mavenJarProperty.charAt( 0 ) ) ) to this: if ( Character.isDigit( mavenJarProperty.charAt( 0 ) ) || "SNAPSHOT".equals(mavenJarProperty) )

Hide

Permalink

Brett Porter added a comment - 04/Dec/04 2:05 AM

applied, though as an indexOf for consistency (even though in this case it is redundant).

Show

Brett Porter added a comment - 04/Dec/04 2:05 AM applied, though as an indexOf for consistency (even though in this case it is redundant).

People

Assignee:

Brett Porter

Reporter:

Jon Strayer

Vote (0)

Watch (1)

Dates

Created:

19/Nov/04 4:25 PM

Updated:

06/Dec/06 6:45 AM

Resolved:

04/Dec/04 2:05 AM

Time Tracking

Estimated:

15m

Remaining:

15m

Logged:

Not Specified

Maven 1

Jar override does not work when trying to override to SNAPSHOT