[#MAVEN-1511] Jar override does not work when trying to override to SNAPSHOT

Maven 1

Jar override does not work when trying to override to SNAPSHOT

Created: 19/Nov/04 04:25 PM Updated: 06/Dec/06 06:45 AM

Component/s:

model

Affects Version/s:

1.0, 1.0.1

Fix Version/s:

1.0.2

Time Tracking:

Original Estimate:

15 minutes

Remaining Estimate:

15 minutes

Time Spent:

Not Specified

Environment:

All

Issue Links:

Related

This issue is related to:

MAVEN-1821 Jar override doesn't work when using a named-version

Description

« Hide

The code in ArtifactListBuilder that checks the type of override being performed (version or path) just checks that the value of the first character of mavenJarProperty is a digit. If you are tyring to override to SNAPSHOT this doesn't work. If the code was changed from

if ( mavenJarOverride && StringUtils.isNotEmpty(mavenJarProperty) )

if ( mavenJarOverride && (StringUtils.isNotEmpty(mavenJarProperty) ||
"SNAPSHOT".equals(mavenJarProperty)))

then we'd be able to override to SNAPSHOT for integration builds and not have to change all the dependencies before a relase (and then back to SNAPSHOT after).

All

Comments

Work Log

Change History

Sort Order:

[ Permalink | « Hide ]

Jon Strayer added a comment - 19/Nov/04 04:32 PM

Damn, I hosed the code. It should be changes from this:

if ( Character.isDigit( mavenJarProperty.charAt( 0 ) ) )

to this:

if ( Character.isDigit( mavenJarProperty.charAt( 0 ) ) || "SNAPSHOT".equals(mavenJarProperty) )

[ Permalink | « Hide ]

Brett Porter added a comment - 04/Dec/04 02:05 AM

applied, though as an indexOf for consistency (even though in this case it is redundant).