Maven 1

Inheritence with more than 3 layers does not work

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0
  • Fix Version/s: 1.0.1
  • Component/s: inheritance
  • Labels:
    None
  • Number of attachments :
    1

Description

I have a project with 5 layers each inheriting from its parent layer.

layer1
layer1/maven.xml
layer1/project.properties
layer1/layer2
layer1/layer2/project.xml
layer1/layer2/project.properties
layer1/layer2/layer3
layer1/layer2/layer3/project.xml
layer1/layer2/layer3/layer4
layer1/layer2/layer3/layer4/project.xml
layer1/layer2/layer3/layer4/layer5
layer1/layer2/layer3/layer4/layer5/project.xml
layer1/project.xml

In the layer1, I have defined a property, and I have defined a goal in the layer1 maven.xml to echo the value of that property.

When I use the multiproject goals ( maven -Dgoal=build multiproject:goal ) from layer1, layer2 inheritence works fine.

1 option is to fix the MavenUtils.java
— MavenUtils.java Tue Aug 10 08:48:30 2004
+++ MavenUtils.java.fix1 Tue Aug 10 08:40:13 2004
@@ -810,7 +810,7 @@
String key = (String) i.next();
Object value;

  • if ( context.getVariable( key ) == null )
    + if ( context.getVariables().get( key ) == null )
    {
    value = map.get( key );

Another option is to look at JellyContext.java. The getVariable function only looks at the parent variables, not all its ancestors.

/** @return the value of the given variable name */
public Object getVariable(String name) {
Object value = variables.get(name);

if ( value == null && isInherit() ) {
JellyContext parent = getParent();
if (parent != null)

{ value = parent.getVariable( name ); }

}

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. MAVEN-1404 ClassCastException in the debug log when inheriting an undefined property

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. MAVEN-1479 Multiproject inheritance (again)

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Carlos Sanchez added a comment -

Could you check the output of maven -X to see if there's any exception?

This sounds related to MPMULTIPROJECT-39 and MAVEN-1404

Show
Carlos Sanchez added a comment - Could you check the output of maven -X to see if there's any exception? This sounds related to MPMULTIPROJECT-39 and MAVEN-1404
Hide
Permalink
Eric Lapierre added a comment -

I see the same Exceptions with the debug log. However, I don't believe that the ClassCastException is the root cause of the problem.

Show
Eric Lapierre added a comment - I see the same Exceptions with the debug log. However, I don't believe that the ClassCastException is the root cause of the problem.
Hide
Permalink
Eric Lapierre added a comment -

Here is a simple testcase.
To reproduce the problem
unzip 1422.zip
cd target1/target2/target3
maven -Dgoal=build multiproject:goal

Show
Eric Lapierre added a comment - Here is a simple testcase. To reproduce the problem unzip 1422.zip cd target1/target2/target3 maven -Dgoal=build multiproject:goal
Hide
Permalink
Edwin Chiu added a comment -

Seen MAVEN-1479 for a possible fix

Show
Edwin Chiu added a comment - Seen MAVEN-1479 for a possible fix
Hide
Permalink
Edwin Chiu added a comment -

This defect should be reopened as the attached test case (1422.zip) still fails.

Here's the output

C:\devel\projects\maven-bugs\1422\layer1\layer2\layer3>maven -Dgoal=build multip
roject:goal
__ __

\/ __ Apache_ ___
  \/ / ` \ V / -) ' \ ~ intelligent projects ~
_   _,_ _/___ _ _ v. 1.0.1

build:start:

build:
[echo] variable SARPLUGINVER 1.0

multiproject:projects-init:
[echo] Gathering project list
Starting the reactor...
Our processing order:
layer5
layer4
+----------------------------------------

Gathering project list layer5
Memory: 4M/6M
+----------------------------------------
+----------------------------------------
Gathering project list layer4
Memory: 4M/6M
+----------------------------------------
Starting the reactor...
Our processing order:
layer5
layer4
+----------------------------------------
Executing true layer5
Memory: 4M/6M
+----------------------------------------

BUILD FAILED
File...... C:\Documents and Settings\utomatoe\.maven\cache\maven-multiproject-plugin-1.3.1\plugin.jelly
Element... maven:reactor
Line...... 217
Column.... 9
Unknown goal "true"
Total time: 2 seconds
Finished at: Tue Nov 16 17:52:17 EST 2004

Show
Edwin Chiu added a comment - This defect should be reopened as the attached test case (1422.zip) still fails. Here's the output C:\devel\projects\maven-bugs\1422\layer1\layer2\layer3>maven -Dgoal=build multip roject:goal __ __ \/ __ Apache _ ___   \/ / ` \ V / - ) ' \ ~ intelligent projects ~ _   _ ,_ _/___ _ _ v. 1.0.1 build:start: build: [echo] variable SARPLUGINVER 1.0 multiproject:projects-init: [echo] Gathering project list Starting the reactor... Our processing order: layer5 layer4 +---------------------------------------- Gathering project list layer5 Memory: 4M/6M +---------------------------------------- +---------------------------------------- Gathering project list layer4 Memory: 4M/6M +---------------------------------------- Starting the reactor... Our processing order: layer5 layer4 +---------------------------------------- Executing true layer5 Memory: 4M/6M +---------------------------------------- BUILD FAILED File...... C:\Documents and Settings\utomatoe\.maven\cache\maven-multiproject-plugin-1.3.1\plugin.jelly Element... maven:reactor Line...... 217 Column.... 9 Unknown goal "true" Total time: 2 seconds Finished at: Tue Nov 16 17:52:17 EST 2004
Hide
Permalink
Brett Porter added a comment -

works for me

Show
Brett Porter added a comment - works for me
Hide
Permalink
Edwin Chiu added a comment -

Works for me now too. For some reason one of my scripts was calling
"maven -Dgoal build multiproject:goal"

when it should have been

"maven -Dgoal=build multiproject:goal"

Sorry 'bout that!

Show
Edwin Chiu added a comment - Works for me now too. For some reason one of my scripts was calling "maven -Dgoal build multiproject:goal" when it should have been "maven -Dgoal=build multiproject:goal" Sorry 'bout that!

People

  • Assignee:
    Unassigned
    Reporter:
    Eric Lapierre
Vote (1)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: