Maven 1

upgrade jelly to CVS HEAD

Details

  • Type: Task Task
  • Status: Closed Closed
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.1-beta-1
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

attempt to use the most recent CVS of jelly and jexl - build new snapshots.

If it is a lot of work, this may not be attempted and removed from 1.1

Issue Links

This issue is depended upon by:
MAVEN-1400 attempt an upgrade to ant 1.6.2 Blocker Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Brett Porter added a comment -

I have attempted this and it progressed well - bootstrap & touchstone were successful.

I have failures in the plugin tests, but I'm not sure if they already existed - will investigate further before committing.

Show
Brett Porter added a comment - I have attempted this and it progressed well - bootstrap & touchstone were successful. I have failures in the plugin tests, but I'm not sure if they already existed - will investigate further before committing.
Hide
Permalink
Brett Porter added a comment -

a bug was resolved in the tests for MavenUtils. With the new Jelly version, environment variables are all available in the context and take precendence over everything (same behaviour as Maven itself).

The only plugin test failing that wasn't already broken is javadoc (and dist when it hits javadoc). This is because ${plugin.resources} is empty. Investigating before committing.

Show
Brett Porter added a comment - a bug was resolved in the tests for MavenUtils. With the new Jelly version, environment variables are all available in the context and take precendence over everything (same behaviour as Maven itself). The only plugin test failing that wasn't already broken is javadoc (and dist when it hits javadoc). This is because ${plugin.resources} is empty. Investigating before committing.
Hide
Permalink
Brett Porter added a comment -

the problem was because JellyContext.getVariable() had been changed to use itself instead of findVariable. This caused MavenJellyContext to evaluate the expression in a parent context.

Instead of reverting Jelly, MavenJellyContext now works around this.

Currently building snapshots of jexl and jelly and testing. Will use the releases dion is preparing when they are avialable.

Show
Brett Porter added a comment - the problem was because JellyContext.getVariable() had been changed to use itself instead of findVariable. This caused MavenJellyContext to evaluate the expression in a parent context. Instead of reverting Jelly, MavenJellyContext now works around this. Currently building snapshots of jexl and jelly and testing. Will use the releases dion is preparing when they are avialable.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.