[#MAVEN-1280] Support group ID in jar overrides - jira.codehaus.org

Maven 1

Support group ID in jar overrides

Created: 14/May/04 05:15 AM Updated: 11/Apr/06 05:18 PM

Return to search

Component/s:

core, documentation

Affects Version/s:

1.0-rc4

Fix Version/s:

None

Time Tracking:

Not Specified

File Attachments:

ArtifactListBuilder-2.patch (1 kB)
2.

ArtifactListBuilder-3.patch (2 kB)
3.

ArtifactListBuilder.patch (1 kB)
4.

eclipse-classpath-jelly.patch (1 kB)
5.

project-descriptor.xml (51 kB)
6.

user-guide.xml (63 kB)

Description

« Hide

Maven should add support for project local dependencies where a jar file is stored in one of the lib folders in the project.

Currently there is undocumented support for it using maven.jar.<id> however the use of <id> is deprecated and should be removed.

Another way I can think of is to use the properties project.path and local.path

project.path == dependency relative to the location of the project.xml file. This ensures that you are on the right file by using getParent of the project.getFile() method.

local.path == dependency wherever on the system (just like maven.jar)

This would help speed up migration of ant projects to maven projects.

Sort Order:

[ Permalink | « Hide ]

Archimedes Trajano added a comment - 14/May/04 05:19 AM

Patch to ArtifactListBuilder to implement property driven paths

Archimedes Trajano made changes - 14/May/04 05:19 AM

Field	Original Value	New Value
Attachment		ArtifactListBuilder.patch [ 12114 ]

[ Permalink | « Hide ]

Archimedes Trajano added a comment - 14/May/04 05:25 AM

Updated project-descriptor.xml file containing text.
Having trouble with CVS and cannot do a patch

Archimedes Trajano made changes - 14/May/04 05:25 AM

Attachment

project-descriptor.xml [ 12115 ]

[ Permalink | « Hide ]

Archimedes Trajano added a comment - 14/May/04 05:31 AM

Updated users guide

Archimedes Trajano made changes - 14/May/04 05:31 AM

Attachment

user-guide.xml [ 12116 ]

[ Permalink | « Hide ]

Archimedes Trajano added a comment - 14/May/04 05:33 AM

Updated patch, delete the old one.

Archimedes Trajano made changes - 14/May/04 05:33 AM

Attachment

ArtifactListBuilder-2.patch [ 12117 ]

[ Permalink | « Hide ]

Archimedes Trajano added a comment - 14/May/04 08:05 AM

Better patch, puts in the path separator automatically instead of having to prefix the project paths with a "/"

Archimedes Trajano made changes - 14/May/04 08:05 AM

Attachment

ArtifactListBuilder-3.patch [ 12119 ]

[ Permalink | « Hide ]

Archimedes Trajano added a comment - 14/May/04 08:20 AM

Patch for eclipse plugin

Archimedes Trajano made changes - 14/May/04 08:20 AM

Attachment

eclipse-classpath-jelly.patch [ 12120 ]

Brett Porter made changes - 26/May/04 09:05 AM

Fix Version/s

1.1 [ 10211 ]

[ Permalink | « Hide ]

dion gillard added a comment - 26/May/04 12:30 PM

How is maven.jar.override undocumented?

According to http://maven.apache.org/reference/user-guide.html#Overriding_Stated_Dependencies

the <id> you mention is artifactId, not id.

[ Permalink | « Hide ]

Archimedes Trajano added a comment - 26/May/04 02:42 PM

But where would you specify the groupId? One of the reasons for the patch was to allow

<groupId>struts</groupId>
<artifactId>struts</artifactId>

<groupId>myclosedsourcecompany</groupId>
<artifactId>struts</artifactId>

[ Permalink | « Hide ]

Archimedes Trajano added a comment - 27/May/04 01:01 PM

Also its not documented in the list of properties here

http://maven.apache.org/reference/user-guide.html#Behavioural_Properties

I think most people if they find out about this list would go there to find out some of the core properties of maven and may not look further down. That document is getting long already as well anyway, perhaps if it was broken down as well for the next release (though the long version of the page is still provided for printing purposes).

Jason van Zyl made changes - 21/Jul/04 09:53 AM

Fix Version/s

1.1 [ 10211 ]

[ Permalink | « Hide ]

Brett Porter added a comment - 23/Jul/04 01:22 PM

we need to use a proper id for jar overrides and document it in 1.1.

I'd suggest maven.jar.groupId.artifactId (but also look for just artifactId to be backwards compatible).

eg
maven.jar.org.apache.maven.maven = maven.jar

Brett Porter made changes - 23/Jul/04 01:22 PM

Fix Version/s

1.1 [ 10211 ]

[ Permalink | « Hide ]

Archimedes Trajano added a comment - 23/Jul/04 05:52 PM

Not sure about your example.
Since you have maven.jar.org.apache.maven.maven should it just be maven.jar.maven.maven ?

[ Permalink | « Hide ]

Carlos Sanchez added a comment - 23/Jul/04 07:21 PM

Remember to allow other dependency types
maven.war.[]
maven.ejb.[]

[ Permalink | « Hide ]

Brett Porter added a comment - 26/Jul/04 08:29 AM

Archimedas: yes, now it is maven.maven. Sorry, I was thinking in future-tense

Carlos: good point. To make it more clear, perhaps:
maven.override.jar.groupId.artifactId = <version | filename>

I know its long, but it should suffice.

Brett Porter made changes - 02/Dec/04 09:47 PM

Fix Version/s	1.1 [ 10211 ]
Fix Version/s		1.1-beta-1 [ 11371 ]
Summary	Support project local dependencies	Support group ID in jar overrides

Brett Porter made changes - 16/May/05 02:52 AM

Fix Version/s	1.1-beta-1 [ 11371 ]
Fix Version/s		1.1-beta-2 [ 10211 ]

Vincent Massol made changes - 11/Aug/05 11:46 AM

Workflow

jira [ 25290 ]

Maven [ 38429 ]

Brett Porter made changes - 23/Aug/05 05:54 AM

Fix Version/s		1.1-rc1 [ 11971 ]
Fix Version/s	1.1-beta-2 [ 10211 ]

Brett Porter made changes - 08/Mar/06 10:47 PM

Workflow

Maven [ 38429 ]

Maven New [ 51738 ]

Arnaud Heritier made changes - 11/Apr/06 05:18 PM

Fix Version/s	1.1-rc1 [ 11971 ]
Fix Version/s		1.1-beta-4 [ 12553 ]