Maven 1

Goals from plugin dependencies fail if the plugin is installed as part of the build process

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0-rc3
  • Fix Version/s: 1.0-rc3
  • Component/s: None
  • Labels:
    None
  • Environment:
    Windows XP, JDK 1.4.2_03
  • Number of attachments :
    0

Description

I have a project consisting of multiple subprojects. One of these subprojects includes a plugin which is built and installed via "plugin:install" during my project build. A goal is then used from this previously installed plugin to build the rest of the project's subprojects (in other words other subprojects have a dependency on this plugin which is installed during the build process).

Using maven-rc1 this used to be no problem, but as of yesterday (I checked out and built MAVEN-1_0_Branch) using rc3 this fails. If the plugin doesn't already exist in the $

{maven.home}/plugins directory things work fine (if I delete the plugin out before the build starts), the plugin is installed and other subprojects needing to use goal(s) from this plugin find it and the build completes successfully. But if the plugin already exists in ${maven.home}

/plugins, I'll get something like below telling me it can't parse the project.xml, when it fact that file does exist, or I sometimes get a message telling me the plugin.jelly from that plugin can't be found:

BUILD FAILED
File...... file:/H:/Documents and Settings/Administrator/.maven/plugins/maven-multiproject-plugin-1.2/plugin.jelly
Element... maven:reactor
Line...... 202
Column.... 9
Unable to obtain goal [multiproject:install-callback] – file:/I:/java/eclipse/andromda-all/metafacades/uml/maven.xml:17
:42: <attainGoal> Error parsing project.xml 'H:\Documents and Settings\Administrator\.maven\plugins\maven-andromda-plugi
n-3.0-SNAPSHOT\project.xml'
Total time: 23 seconds

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Brett Porter added a comment -

I'm somewhat surprised this could have ever worked, and a bit confused as to what is actually happening. What is the behaviour under RC2? Some improvements to the cache happened on CVS since, but I would think it was the plugin loading changes in RC2 that changed the behaviour.

plugin installation is not seamless and I would recommend using plugin:install as part of a build process. What I think you want is to build the plugin, copy it to the repository, the load it via a plugin dependency? Unfortunately this is not what plugin:install does at present.

Show
Brett Porter added a comment - I'm somewhat surprised this could have ever worked, and a bit confused as to what is actually happening. What is the behaviour under RC2? Some improvements to the cache happened on CVS since, but I would think it was the plugin loading changes in RC2 that changed the behaviour. plugin installation is not seamless and I would recommend using plugin:install as part of a build process. What I think you want is to build the plugin, copy it to the repository, the load it via a plugin dependency? Unfortunately this is not what plugin:install does at present.
Hide
Permalink
Chad Brandon added a comment -

I never moved to rc2 because of the fact that any plugin that was installed to the repository during the build process (one that was marked as a dependency in my project.xml) the goals weren't found and the build failed. I filled a bug on this and you fixed it a week or so ago. So I figured I would try out the latest rc3 build and now I'm running into this error.

Our plugin is part of our over all project and basically this plugin is one of the first submodules installed into the local repository using plugin:install. It is then used to build the rest of the project (other modules have it marked as a plugin dependency). Our project builds itself (similar to Maven). It would be nice to not have to install it first into the remote repository as a seperate step. Why wouldn't you expect this to work?

The strange thing is, that it does work if the plugin is not in the $MAVEN_HOME/plugins directory, but when its there (any subsequent build after the first), I get these build failures telling me it can't either parse the project.xml or the plugin.jelly of the plugin.

Show
Chad Brandon added a comment - I never moved to rc2 because of the fact that any plugin that was installed to the repository during the build process (one that was marked as a dependency in my project.xml) the goals weren't found and the build failed. I filled a bug on this and you fixed it a week or so ago. So I figured I would try out the latest rc3 build and now I'm running into this error. Our plugin is part of our over all project and basically this plugin is one of the first submodules installed into the local repository using plugin:install. It is then used to build the rest of the project (other modules have it marked as a plugin dependency). Our project builds itself (similar to Maven). It would be nice to not have to install it first into the remote repository as a seperate step. Why wouldn't you expect this to work? The strange thing is, that it does work if the plugin is not in the $MAVEN_HOME/plugins directory, but when its there (any subsequent build after the first), I get these build failures telling me it can't either parse the project.xml or the plugin.jelly of the plugin.
Hide
Permalink
Chad Brandon added a comment -

On yeah and one more thing - as part of the plugin:install, I perform a postGoal step which does copy it to the local repository (like you were saying I should do)

Show
Chad Brandon added a comment - On yeah and one more thing - as part of the plugin:install, I perform a postGoal step which does copy it to the local repository (like you were saying I should do)
Hide
Permalink
Brett Porter added a comment -

I've got this pretty much resolved, just doing some testing. The solution is to install and uninstall the plugin from the cache on the fly.

Show
Brett Porter added a comment - I've got this pretty much resolved, just doing some testing. The solution is to install and uninstall the plugin from the cache on the fly.
Hide
Permalink
Brett Porter added a comment -

ok, this works really nicely now.

I'll give it a bootstrap tonight to make sure everything is happy and commit tomorrow.

Show
Brett Porter added a comment - ok, this works really nicely now. I'll give it a bootstrap tonight to make sure everything is happy and commit tomorrow.
Hide
Permalink
Chad Brandon added a comment -

Great thanks for fixing it Brett!

Show
Chad Brandon added a comment - Great thanks for fixing it Brett!
Hide
Permalink
Brett Porter added a comment -

fixed.

Here's the catch: so I didn't break any existing behaviour, I have implemented this as a new goal.

use plugin:install-now instead of plugin:install and this should work. It will install it in the user plugin cache instead of the maven installation, and into the running instance.

If you need it to install into the global maven instance for later invocations by other users, you can use plugin:install and plugin:install-now in conjunction.

Show
Brett Porter added a comment - fixed. Here's the catch: so I didn't break any existing behaviour, I have implemented this as a new goal. use plugin:install-now instead of plugin:install and this should work. It will install it in the user plugin cache instead of the maven installation, and into the running instance. If you need it to install into the global maven instance for later invocations by other users, you can use plugin:install and plugin:install-now in conjunction.
Hide
Permalink
Nick Sieger added a comment -

So how would I use plugin:install-now instead of plugin:install when using the multiproject plugin with a goal of multiproject:install and a project artifact type of plugin? Would that case be possible?

Show
Nick Sieger added a comment - So how would I use plugin:install-now instead of plugin:install when using the multiproject plugin with a goal of multiproject:install and a project artifact type of plugin? Would that case be possible?
Hide
Permalink
Brett Porter added a comment -

sorry, but the plugin plugin doesn't match the artifact interface, so can't really be used with multiproject.

The best way to do this is probably to define your own type and write a custom goal. ie

project.properties:
maven.multiproject.type=custom

maven.xml:
<goal name="custom:install" prereqs="plugin:install-now" />

Show
Brett Porter added a comment - sorry, but the plugin plugin doesn't match the artifact interface, so can't really be used with multiproject. The best way to do this is probably to define your own type and write a custom goal. ie project.properties: maven.multiproject.type=custom maven.xml: <goal name="custom:install" prereqs="plugin:install-now" />

People

  • Assignee:
    Brett Porter
    Reporter:
    Chad Brandon
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: