goal mapper does not follow j:import tags

dion gillard added a comment - 11/Feb/04 11:54 PM Sample

Brett Porter added a comment - 21/Feb/04 6:59 PM this is only because it is using j:import - if it is in a plugin or in maven.xml itself it works fine. There's another bug around like this.

Brett Porter added a comment - 23/Mar/04 7:18 PM had to rollback change

Brett Porter added a comment - 23/Mar/04 7:19 PM this is problematic as uri may be an expression which cannot be evaluated at this point. Don't see this being fixed in maven1

dion gillard added a comment - 23/Mar/04 7:36 PM Should we start a list of known issues for maven 1.0?

dion gillard added a comment - 23/Mar/04 7:37 PM Would it be possible to just implement the case where the uri is not an expression and document the expression as a known limitation?

Brett Porter added a comment - 23/Mar/04 7:40 PM sure - but I don't see this happening a lot in the real world so its an edge case.

Brett Porter added a comment - 25/Mar/04 1:14 AM fixed again!

Anthony F. added a comment - 31/Mar/04 10:51 AM Hi! With maven-1.0-rc1, I used to import a globally shared jelly script from my subprojects maven.xml file, using something like that: <project xmlns:j="jelly:core"> <j:include file="$ {myGlobalVariable}/mySubDirectory/mySharedScript.jelly" /> </project> Now and since the 1.0-rc2, I use <j:import/> instead of <j:include/> tag but, as you explained, expressions are not parsed here. Gasp'. So, I've modified the maven-1.0-rc3-SNAPSHOT PluginScriptParser class and it fixes my problem, allowing me to use a global variable. I've added one static member: - >< ----------------------------- /** Maven Expression Factory. */ private static MavenExpressionFactory mavenExpressionFactory = new MavenExpressionFactory(); - >< ----------------------------- and inside the startElement(String, String, String, Attributes) method, I've replaced the three following comment lines: - >< ----------------------------- // We could evaluate this as an expression, but the only thing set at this point is ${basedir} // and some expressions will spit out exceptions (eg ${context.getVariable('blah')}) // TODO: maybe sub in basedir, plugin.resources and plugin.dir? - >< ----------------------------- by: - >< ----------------------------- // Quick fix for evaluating simple expressions such as // <j:import file="${myGlobalVariable} /mySubDir/myScript.jelly"/> // // It will crash if you use some more complex objects in // your expression. try { MavenJellyContext context = jellyScriptHousing.getProject().getContext(); if ( context != null ) { log.debug( rawName + " try to evalutate uri attribute as an expression." ); Expression expr = JellyUtils.decomposeExpression( importUri, mavenExpressionFactory, context ); importUri = expr.evaluateAsString( context ); } } catch ( Exception e ) { log.error( rawName + " can't evaluate uri attribute, bypassing." ); } - >< ----------------------------- I hope this may help, even if it doesn't support all cases. Bye bye, Thonio –

Brett Porter added a comment - 31/Mar/04 6:45 PM "// It will crash if you use some more complex objects in your expression. " And this is exactly why this change won't be put into the parser Goals will still be used from the included script as long as you can convince Maven to use the plugin containing itself - use a dependency hook to do this. If this is in maven.xml, just ignore the warnings