Maven 1

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.0-rc2
• Fix Version/s: 1.0-rc4
• Component/s: core
• Labels:

  None
• Environment:

  any

The current ArtifactType enumeration does not include support for EJB-client jars. In fact, the ejb plugin currently fabricates the jar name and has no support for handling the EJB-client jar, only creating it in the ${maven.build.dir} directory. In addition, the Dependency class cannot recognize EJB-client jars by type and add them to the classpath.

I propose adding an EJB_CLIENT ArtifactType with type="ejb-client" and extension="client.jar". This will result in repository pathing of <group-id>/ejb-clients/<artifact-id>.client.jar for vanilla EJB projects.

Toward this goal, I have modified the ArtifactType.findType() method to search an array containing all type constants, in order to simplify future additions to this class.

I also added an ArtifactType.JAR constant, for consistency.

Finally, I modified the Dependency.isAddedToClasspath() method to use the ArtifactType constants for JAR, EJB, and EJB_CLIENT for comparisons with the stated type name, and finally returning false if none of these match on the getType() method.

I will be submitting another patch against the maven-plugins project, for the ejb plugin and the artifact plugin...this patch (which I guess I'll submit to both MPxxx pseudo-projects on JIRA...) will enable EJB-client support and improve the artifact plugin to take full advantage of the ArtifactType enumeration. I'll update this issue with the appropriate JIRA issue ID's when I have them.

Attached is a patch for the maven-core.

1. 

   maven-artifact-cleanup-for-ejbclients.patch

   08/Dec/03 2:51 PM

   4 kB

   John Casey

• Assignee:

  Unassigned

  Reporter:

  John Casey

• Created:

  08/Dec/03 2:50 PM

  Updated:

  08/Mar/06 10:47 PM

  Resolved:

  23/Jul/04 1:45 AM