jira.codehaus.org

  • Log In Access more options
    • Online Help
    • Keyboard Shortcuts
    • About JIRA
    • JIRA Credits
    • What?s New
  • Dashboards Access more options (Alt+d)
  • Projects Access more options (Alt+p)
  • Issues Access more options (Alt+i)
  • Maven 2.x Assembly Plugin
  • MASSEMBLY-599

Mistake in javadoc for dependencySet/includes

  • Log In
  • Views
    • XML
    • Word
    • Printable

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 2.2.2, 2.3
  • Fix Version/s: None
  • Labels:
    None

Description

Here it's stated that fully qualified artifact coordinates in dependencySet/includes/include* should be in form
*groupId:artifactId:type:version[:classifier]*

But actually accepted following form
*groupId:artifactId:type[:classifier]:version*

Fragment of source calculating artifact.id for filtering:

.m2/repository/org/apache/maven/maven-artifact/2.2.1/maven-artifact-2.2.1-sources.jar!/org/apache/maven/artifact/DefaultArtifact.java
public String getId()
    {
        return getDependencyConflictId() + ":" + getBaseVersion();
    }

    public String getDependencyConflictId()
    {
        StringBuffer sb = new StringBuffer();
        sb.append( getGroupId() );
        sb.append( ":" );
        appendArtifactTypeClassifierString( sb );
        return sb.toString();
    }

    private void appendArtifactTypeClassifierString( StringBuffer sb )
    {
        sb.append( getArtifactId() );
        sb.append( ":" );
        sb.append( getType() );
        if ( hasClassifier() )
        {
            sb.append( ":" );
            sb.append( getClassifier() );
        }
    }

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. MASSEMBLY-567 Version wildcard in dependencySet include does not work

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

  • All
  • Comments
  • Work Log
  • History
  • Activity
Hide
Permalink
Björn Streicher added a comment - 16/Apr/12 3:24 AM - edited

In addition, I think the description for all include and exclude-directives at https://maven.apache.org/plugins/maven-assembly-plugin/assembly.html is also wrong. Please correct!

By the way, it is described correctly on https://maven.apache.org/plugins/maven-assembly-plugin/examples/single/including-and-excluding-artifacts.html

Show
Björn Streicher added a comment - 16/Apr/12 3:24 AM - edited In addition, I think the description for all include and exclude-directives at https://maven.apache.org/plugins/maven-assembly-plugin/assembly.html is also wrong. Please correct! By the way, it is described correctly on https://maven.apache.org/plugins/maven-assembly-plugin/examples/single/including-and-excluding-artifacts.html

People

  • Assignee:
    Unassigned
    Reporter:
    Alexander Kormushin
Vote (0)
Watch (2)

Dates

  • Created:
    08/Feb/12 5:26 AM
    Updated:
    11/May/12 5:56 AM
  • Atlassian JIRA (v5.0.4#731-sha1:3aa7374)
  • Report a problem
  • Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.