Maven Assembly Plugin
  1. Maven Assembly Plugin
  2. MASSEMBLY-591

Empty classifier in dependency causes extra dash

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.2
    • Fix Version/s: 2.4
    • Component/s: None
    • Labels:
      None
    • Testcase included:
      yes
    • Number of attachments :
      2

      Description

      When having a dependency with an empty classifier element, adding it as a dependency set causes an extra dash to appear in the file name.
      For example, when I add a dependency of this type (notice the empty classifier element):

      [snip]
      <dependency>
      <groupId>org.apache.tiles</groupId>
      <artifactId>tiles-api</artifactId>
      <version>2.2.2</version>
      <classifier />
      </dependency>
      [/snip]

      and I put it inside the assembly descriptor:
      [snip]
      <dependencySets>
      <dependencySet>
      <outputDirectory>/</outputDirectory>
      </dependencySet>
      </dependencySets>
      [/snip]

      I see that the tiles-api jar contains an extra dash in its name:
      tiles-api-2.2.2-.jar

        Activity

        Hide
        Antonio Petrelli added a comment -

        Using Maven 3.0.3 as a dependency for maven-assembly-plugin the bug still exists.

        Show
        Antonio Petrelli added a comment - Using Maven 3.0.3 as a dependency for maven-assembly-plugin the bug still exists.
        Hide
        Antonio Petrelli added a comment -

        Added patch to fix the problem locally to maven-assembly-plugin.

        Show
        Antonio Petrelli added a comment - Added patch to fix the problem locally to maven-assembly-plugin.
        Hide
        Dennis Lundberg added a comment -

        Patch applied in r1401695.
        Thank you!

        Show
        Dennis Lundberg added a comment - Patch applied in r1401695. Thank you!
        Hide
        Antonio Petrelli added a comment -

        Wow I almost forgot about this bug. 10 months to apply a patch... Anyway thank you.

        Show
        Antonio Petrelli added a comment - Wow I almost forgot about this bug. 10 months to apply a patch... Anyway thank you.
        Hide
        Dennis Lundberg added a comment -

        Yeah, we have like 3000+ unresolved issues in total for Maven, and 150 of those are for the Assembly plugin alone. So unfortunately it can take a while for a patch to be applied. Thanks again for the patch!

        Show
        Dennis Lundberg added a comment - Yeah, we have like 3000+ unresolved issues in total for Maven, and 150 of those are for the Assembly plugin alone. So unfortunately it can take a while for a patch to be applied. Thanks again for the patch!

          People

          • Assignee:
            Dennis Lundberg
            Reporter:
            Antonio Petrelli
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: