Maven Assembly Plugin
  1. Maven Assembly Plugin
  2. MASSEMBLY-557

Corrupted zip created by assembly: extracting the zip forgets certain folders (or throws permission denied errors) possibly because zip index is corrupted

    Details

    • Type: Bug Bug
    • Status: Open Open
    • Priority: Critical Critical
    • Resolution: Unresolved
    • Affects Version/s: 2.2.1
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Number of attachments :
      1

      Description

      Take a look at the attached zip created by the assembly plugin.

      • If you open it, you can see navigate to the submap /droolsjbpm-integration-distribution-5.2.0.M2/reference_manual/pdf/. In that map you find the file droolsjbpm-integration-docs.pdf which you can open with a PDF reader.
      • If instead you extract the entire archive to a directory, and navigate to the submap /droolsjbpm-integration-distribution-5.2.0.M2/reference_manual/pdf/, you 'll find that that map is unreadable (chmod 000) and the pdf file is gone.
        The directories html_single and html suffer the same fate, but none of the other directories do.

      I used the default linux Ubuntu 10.10 archive manager (which according to about screen is called "File-roller 2.32.0").
      I used Maven 3.0.3, maven-assembly-plugin 2.2.1.
      Note that that attached zip is gutted to stay inside the maximum file upload size.

      Possible reproduce recipe:

      git clone git@github.com:droolsjbpm/droolsjbpm-integration.git
      cd droolsjbpm-integration
      git checkout 5.2.0.M2
      mvn clean install -DskipTests -Dfull
      cd droolsjbpm-integration/target
      ls
      
      checkdir error:  cannot create /home/gdesmet/tmp/releases/problem_with_the_release_zip/droolsjbpm-integration-distribution-5.2.0.M2/reference_manual/html_single/images
                       Permission denied
                       unable to process droolsjbpm-integration-distribution-5.2.0.M2/reference_manual/html_single/images/.
      ...
      

        Activity

        Hide
        Geoffrey De Smet added a comment -

        @Kristian it's random (not always reproducable). However, since no one linked a commit to the assembly plugin that defaults the directoryMode correctly, it's probably still in there.

        Show
        Geoffrey De Smet added a comment - @Kristian it's random (not always reproducable). However, since no one linked a commit to the assembly plugin that defaults the directoryMode correctly, it's probably still in there.
        Hide
        Kristian Rosenvold added a comment -

        @Geoffery; the default file modes originate within plexus-archiver. Our linking to commits in plexus is somewhat arbitrary. There is a fair chance this issue is fixed since I vaguely recall fixing something about file attributes in plexus

        Show
        Kristian Rosenvold added a comment - @Geoffery; the default file modes originate within plexus-archiver. Our linking to commits in plexus is somewhat arbitrary. There is a fair chance this issue is fixed since I vaguely recall fixing something about file attributes in plexus
        Hide
        Christoph Gritschenberger added a comment - - edited

        I just tested again with maven-assembly-plugin-2.4-20121112.092019-526.jar
        Behavior is still the same. We still have to stick with the above workaround.

        BTW: it's 100% reproducible for me when following the steps I described earlier (https://jira.codehaus.org/browse/MASSEMBLY-557?focusedCommentId=295409&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-295409)

        Show
        Christoph Gritschenberger added a comment - - edited I just tested again with maven-assembly-plugin-2.4-20121112.092019-526.jar Behavior is still the same. We still have to stick with the above workaround. BTW: it's 100% reproducible for me when following the steps I described earlier ( https://jira.codehaus.org/browse/MASSEMBLY-557?focusedCommentId=295409&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-295409 )
        Hide
        Kristian Rosenvold added a comment - - edited

        I just upgraded 2.5-SNAPSHOT to the latest plexus-archiver. We've had some pretty significant bug fixes on file modes in archiver, so you may want to test 2.5-SNAPSHOT in a few hours when it hits repository.apache.org

        Show
        Kristian Rosenvold added a comment - - edited I just upgraded 2.5-SNAPSHOT to the latest plexus-archiver. We've had some pretty significant bug fixes on file modes in archiver, so you may want to test 2.5-SNAPSHOT in a few hours when it hits repository.apache.org
        Hide
        Kristian Rosenvold added a comment -

        Has this issue been fixed in assembly 2.4 ?

        Show
        Kristian Rosenvold added a comment - Has this issue been fixed in assembly 2.4 ?

          People

          • Assignee:
            Unassigned
            Reporter:
            Geoffrey De Smet
          • Votes:
            4 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated: