Maven 2.x Assembly Plugin

filtering broken in files containing '@'

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.2
  • Fix Version/s: 2.2.1
  • Component/s: None
  • Labels:
    None
  • Environment:
  • Testcase included:
    yes
  • Number of attachments :
    1

Description

Files containing the '@' sign as eg within e-mail URLs are only filtered up to the occurrence of this sign.

To check this, unpack the attached ZIP, cd into the created directory 'filter-test-01' and run

mvn assembly:single

The created target/filter-test-1.0-filtertest.zip contains a README, which has only the first occurrence of $

{project.artifactId}

replaced, but not the second one.

Issue Links

depends upon

Bug - A problem which impairs or prevents the functions of the product. MSHARED-176 Add support of stopping at the end of line to prevent issue with endToken not found

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is duplicated by

Bug - A problem which impairs or prevents the functions of the product. MASSEMBLY-525 Ant Tokens can now be multi-line when filtering - regression from 2.2-beta-5

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
TJ Rothwell added a comment - - edited

I noticed this with .bat files. Since $

{var}

and @var@ both work, I think it has to do with the pattern matching. This should be a higher severity level.

<file-doesn't work>
@echo off
$

{cmd} ${args}


<file-workaround>
@echo off
rem @ (matching 'at')
${cmd}

$

{args}
Show
TJ Rothwell added a comment - - edited I noticed this with .bat files. Since $ {var} and @var@ both work, I think it has to do with the pattern matching. This should be a higher severity level. <file-doesn't work> @echo off $ {cmd} ${args} <file-workaround> @echo off rem @ (matching 'at') ${cmd} $ {args}
Hide
Permalink
Dennis Lundberg added a comment -

To fix this we need to update to maven-filtering 1.0.

Show
Dennis Lundberg added a comment - To fix this we need to update to maven-filtering 1.0.
Hide
Permalink
Dennis Lundberg added a comment -

Updated to maven-filtering 1.0-SNAPSHOT in r1066942.
New 2.2.1-SNAPSHOT of the assembly plugin deployed. Please test it.

Show
Dennis Lundberg added a comment - Updated to maven-filtering 1.0-SNAPSHOT in r1066942 . New 2.2.1-SNAPSHOT of the assembly plugin deployed. Please test it.
Hide
Permalink
Dennis Lundberg added a comment -

The supplied sample project works if I update maven-assembly-plugin to 2.2.1-SNAPSHOT.

Show
Dennis Lundberg added a comment - The supplied sample project works if I update maven-assembly-plugin to 2.2.1-SNAPSHOT.

People

  • Assignee:
    Dennis Lundberg
    Reporter:
    Alexander Rettig
Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: