Maven 2.x Assembly Plugin

Fix bogus warning about attaching non-regular file

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Fixed
  • Affects Version/s: 2.2-beta-2
  • Fix Version/s: 2.2
  • Component/s: None
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    2

Description

If an archive file is configured with attach=false, the plugin will output the following warning because the underlying if-else is wrong:

[WARNING] Assembly file: <snip>.zip is not a regular file (it may be a directory).
  It cannot be attached to the project build for installation or deployment.

The warning must be guarded with attach=true.

Attachments

  1. Text File
    bogus-attach-warning.patch
    04/Mar/08 7:08 AM
    5 kB
    Benjamin Bentmann
  2. Text File
    trunk-r899849.patch
    15/Jan/10 6:27 PM
    0.8 kB
    Patrick Woodworth

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Patrick Woodworth added a comment -

Attaching an updated patch to fix this issue rebased off latest trunk (now a one-liner).

Show
Patrick Woodworth added a comment - Attaching an updated patch to fix this issue rebased off latest trunk (now a one-liner).
Hide
Permalink
Benjamin Bentmann added a comment -

Patch applied in r900009, thanks!

Show
Benjamin Bentmann added a comment - Patch applied in r900009, thanks!

People

Vote (4)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.