Maven 2.x Assembly Plugin

descriptorSourceDirectory should only scan for xml files.

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.2-beta-2
  • Component/s: None
  • Labels:
    None
  • Testcase included:
    yes
  • Number of attachments :
    3

Description

The descriptorSourceDirectory parameter currently treats all files in the directory like assembly descriptors. Only files ending with .xml should be picked up as descriptors. I noticed this because the assembly plugin keeps trying to use files from my .svn directory as assembly descriptors.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Paul Gier added a comment -

Attaching one line patch to scan only for .xml files.

Show
Paul Gier added a comment - Attaching one line patch to scan only for .xml files.
Hide
Permalink
Benjamin Bentmann added a comment -

An additional approach would be to add the default excludes to the DirectoryScanner to stop it from finding the source control metadata files. Using these excludes might be required if a SCM system keeps the original file extension for the working copy files, e.g. if something like "dir/.fancyscm/base-file.xml" could exist.

Show
Benjamin Bentmann added a comment - An additional approach would be to add the default excludes to the DirectoryScanner to stop it from finding the source control metadata files. Using these excludes might be required if a SCM system keeps the original file extension for the working copy files, e.g. if something like "dir/.fancyscm/base-file.xml" could exist.
Hide
Permalink
Paul Gier added a comment -

Yes, using the default excludes is a good idea. Although I think it should be used in addition to only looking for .xml files because you might put a readme.txt or something like that in the same directory as your assemblies (like in the integration test).

Show
Paul Gier added a comment - Yes, using the default excludes is a good idea. Although I think it should be used in addition to only looking for .xml files because you might put a readme.txt or something like that in the same directory as your assemblies (like in the integration test).
Hide
Permalink
John Casey added a comment -

Patches applied, and an extra unit test method was added to the descriptor-reader tests. Thanks guys!

Show
John Casey added a comment - Patches applied, and an extra unit test method was added to the descriptor-reader tests. Thanks guys!

People

  • Assignee:
    John Casey
    Reporter:
    Paul Gier
Vote (2)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: