Maven 2.x Assembly Plugin

In format dir, be able to create a dir without the suffix .dir

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.2-beta-1
  • Fix Version/s: 2.2-beta-3
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

For a assembly in format directory, it would be nice to be able to get rid of the format suffix (".dir").

In a general way, I think being able to change the file extension would be nice. This will allow to remote the .dir (make sure le dot is also removable)

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Henri Tremblay added a comment -

I can't change it but maybe priority major is a little bit high.

I know that in the case of multiple formats, it won't work. So maybe the solution is to enrich the assembly descriptor to have:

<format>
<name></name>
<suffix></suffix>
</format>

Where suffix is by default the name.

Show
Henri Tremblay added a comment - I can't change it but maybe priority major is a little bit high. I know that in the case of multiple formats, it won't work. So maybe the solution is to enrich the assembly descriptor to have: <format> <name></name> <suffix></suffix> </format> Where suffix is by default the name.
Hide
Permalink
Benjamin Bentmann added a comment -

The plugin's trunk already supports the suppression of the "dir" suffix via a new mojo parameter:

/**
 * If this flag is set, the ".dir" suffix will be suppressed in the output
 * directory name when using assembly/format == 'dir' and other formats
 * that begin with 'dir'.
 *
 * @parameter default-value="false"
 */
private boolean ignoreDirFormatExtensions;

What I dislike about this is the default value being "false". Sure, that would keep backward compatibility with the existing plugin versions. However, I personally would have called the current behavior a bug. Where on earth do people want to append ".dir" to a directory? Are there really any use-cases for this? If not, I do not see the point in keeping a bug enabled by default. Instead, the philosophy "convention over configuration" should take precedence such that users get the intended behavior out-of-the-box.

Show
Benjamin Bentmann added a comment - The plugin's trunk already supports the suppression of the "dir" suffix via a new mojo parameter: /** * If this flag is set, the ".dir" suffix will be suppressed in the output * directory name when using assembly/format == 'dir' and other formats * that begin with 'dir'. * * @parameter default -value= " false " */ private boolean ignoreDirFormatExtensions; What I dislike about this is the default value being "false". Sure, that would keep backward compatibility with the existing plugin versions. However, I personally would have called the current behavior a bug. Where on earth do people want to append ".dir" to a directory? Are there really any use-cases for this? If not, I do not see the point in keeping a bug enabled by default. Instead, the philosophy "convention over configuration" should take precedence such that users get the intended behavior out-of-the-box.

People

  • Assignee:
    John Casey
    Reporter:
    Henri Tremblay
Vote (5)
Watch (5)

Dates

  • Created:
    Updated:
    Resolved: