Maven 2.x Assembly Plugin

Filters as read-only parameter can break the assembly build of a multi-module project

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.2-beta-1
  • Fix Version/s: 2.2-beta-2
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    2

Description

When I specify <build><filters> in the root project for filtering files of an assembly, then running "assembly:assembly" breaks. This is because <build><filters> configuration is inherited in the modules, and Maven does not correctly inherit this configuration (see MNG-2445).

I attached an example project to test this:

  • run "assembly:attached" on the root project: it works fine
  • run "assembly:assembly" on the root project: it breaks

I think the "filters" argument of the assembly plugin should not be read-only. Instead, it should be possible to redefine it locally, or leave it blank if we want the plugin to take the <build><filters> definition instead.

What do you think of this? I can work on this.

Issue Links

relates to

Bug - A problem which impairs or prevents the functions of the product. MASSEMBLY-183 assembly:attached does not work with filter- ERROR: Cannot override read-only parameter

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Fabrice Bellingard added a comment -

Patch to allow users to specify filters locally tothe assembly plugin. If not specified, the filters get the $

{project.build.filters}

value.

Show
Fabrice Bellingard added a comment - Patch to allow users to specify filters locally tothe assembly plugin. If not specified, the filters get the $ {project.build.filters} value.
Hide
Permalink
John Casey added a comment -

sounds like a fine idea to me, and an easy fix. We'll have to make sure we have the sample build in the integration tests, though...as that helps to explain that we've made a conscious design choice on this point.

Show
John Casey added a comment - sounds like a fine idea to me, and an easy fix. We'll have to make sure we have the sample build in the integration tests, though...as that helps to explain that we've made a conscious design choice on this point.
Hide
Permalink
Fabrice Bellingard added a comment -

Fixed in trunk, with an integration test.

Show
Fabrice Bellingard added a comment - Fixed in trunk, with an integration test.

People

  • Assignee:
    Fabrice Bellingard
    Reporter:
    Fabrice Bellingard
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: