Maven 2.x Assembly Plugin

<outputFileNameMapping> needs to report collision.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.2-beta-1
  • Fix Version/s: 2.2-beta-3
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    1

Description

If <outputFileNameMapping> maps two or more artifacts into the same name, it needs to be reported as an error.

Maven currently just takes the last one without reporting anything, and as a result I didn't notice that my assembly descriptor had a problem until I debug the plugin source code.

This problem is particularly made worse by a broken jar-with-dependencies example in the documentation, which says:

  <dependencySets>
    <dependencySet>
      <outputDirectory></outputDirectory>
      <outputFileNameMapping></outputFileNameMapping>
      <unpack>true</unpack>
      <scope>runtime</scope>
    </dependencySet>
  </dependencySets>

... which maps every dependency to ""

Issue Links

This issue depends upon:
MASSEMBLY-285 regression: duplicate files added to the assembly Blocker Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Cestmír Ruzicka added a comment -

A little patch for archive duplicity.
When archiver contains artifacts file, exception is thrown

Show
Cestmír Ruzicka added a comment - A little patch for archive duplicity. When archiver contains artifacts file, exception is thrown
Hide
Permalink
Cestmír Ruzicka added a comment -

Bad outputFileNameMapping is making duplicities in archive

Show
Cestmír Ruzicka added a comment - Bad outputFileNameMapping is making duplicities in archive
Hide
Permalink
John Casey added a comment -

FWIW, you can now gain a little more control over this using 2.2-beta-3-SNAPSHOT latest code. The fix for MASSEMBLY-285 will also fix this, particularly if you set:

<archiverConfig>
  <duplicateBehavior>fail</duplicateBehavior>
</archiverConfig>

Admittedly, we could probably find a better way of providing a better message for specific instances where mapped artifact file names overlap, but it would be a little confusing if a mapped artifact filename overlapped with another file in the archive that wasn't the result of outputFileNameMapping logic.

Show
John Casey added a comment - FWIW, you can now gain a little more control over this using 2.2-beta-3-SNAPSHOT latest code. The fix for MASSEMBLY-285 will also fix this, particularly if you set: 
<archiverConfig>
  <duplicateBehavior>fail</duplicateBehavior>
</archiverConfig>
Admittedly, we could probably find a better way of providing a better message for specific instances where mapped artifact file names overlap, but it would be a little confusing if a mapped artifact filename overlapped with another file in the archive that wasn't the result of outputFileNameMapping logic.
Hide
Permalink
John Casey added a comment -

BTW, that example of the jar-with-dependencies built-in descriptor is correct; outputFileNameMapping is NOT used when unpack == true.

Show
John Casey added a comment - BTW, that example of the jar-with-dependencies built-in descriptor is correct; outputFileNameMapping is NOT used when unpack == true.

People

Vote (2)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.