Maven Assembly Plugin
  1. Maven Assembly Plugin
  2. MASSEMBLY-184

components are not interpolated - i.e., ${params} are not substituted

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2-beta-2
    • Component/s: None
    • Labels:
      None
    • Environment:
      all
    • Testcase included:
      yes
    • Number of attachments :
      1

      Description

      Components are no more than the extension of an Assembly. As such, they ought to also be interpolated. Why is there the current restriction that the $

      {param} will be replaced when it appears in an Assembly, but not if it appears in a Component?

      Without interpolating Components, it will not be possible to refactor a component out of an assembly if it contains a ${param}

      to be replaced.

      Attached is a diff with the code change and a test case. The change: the call to merge components into the assembly now appears before assembly's interpolation in the DefaultAssemblyReader, not after.

      Regards,
      John

        Issue Links

          Activity

          Hide
          Mark Reynolds added a comment -

          The component feature is not useful for my project without this fix.

          Show
          Mark Reynolds added a comment - The component feature is not useful for my project without this fix.
          Hide
          John Casey added a comment -

          Applied. Great patch, thanks.

          Show
          John Casey added a comment - Applied. Great patch, thanks.

            People

            • Assignee:
              John Casey
              Reporter:
              John J. Franey
            • Votes:
              3 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: