Maven 2.x Assembly Plugin

assembly <files> uses maven parent relative path and not the modules relative path

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.1
  • Fix Version/s: 2.2-beta-1
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    5

Description

In mvn 2.0.4 if I have an assemly descriptor that has the following:

<files>
<file>
<source>src/site/apt/index.apt</source>
<outputDirectory></outputDirectory>
<destName>README.txt</destName>
</file>
</files>

and a maven project that looks like:

Maven Assembly Bug

  • pom.xml
  • assembly-bug-module
  • pom.xml
  • src/site/apt/index.apt

with the assembly:assembly bound to the package phase inside assembly-bug-module/pom.xml as
<build>
<plugins>
<plugin>
<artifactId>maven-assembly-plugin</artifactId>
<executions>
<execution>
<id>package-assembly</id>
<phase>package</phase>
<goals>
<goal>assembly</goal>
</goals>
<configuration>
<descriptors>
<descriptor>
src/main/assembly/bin.xml
</descriptor>
</descriptors>
</configuration>
</execution>
</executions>
</plugin>

then when I run mvn install inside assembly-bug-module:
assembly-bug-module> mvn install
the command works fine

When I run mvn install inside the "Maven Assembly Bug" directory the command will fail
Maven Assembly Bug> mvn install

[INFO] [assembly:assembly

{execution: package-assembly}

]
[INFO] ------------------------------------------------------------------------
[ERROR] BUILD ERROR
[INFO] ------------------------------------------------------------------------
[INFO] Error adding file to archive: <path>\Maven Assembly Bug\src\site\apt\index.apt isn't a file.

Example project is attached as a zip file.

Trying to change the descriptor to use $

{project.build.sourceDirectory} does not work as this is not resoolved.

[INFO] Error adding file to archive: <path>\Maven Assembly Bug\assembly-bug-module\${project.build.sourceDirectory}

\site\apt\index.apt isn't a file.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Barrie Treloar added a comment -

This may be a duplicate of MASSEMBLY-100 which is listed as fixed in 2.2
(at this time 2.2 us unreleased.)

Show
Barrie Treloar added a comment - This may be a duplicate of MASSEMBLY-100 which is listed as fixed in 2.2 (at this time 2.2 us unreleased.)
Hide
Permalink
Dan Tran added a comment -

I am not sure if the fix in MASSEMBLY-100 solves your issue regarding having spaces in the path thou

Best way is to fetch the source and test it your self

-D

Show
Dan Tran added a comment - I am not sure if the fix in MASSEMBLY-100 solves your issue regarding having spaces in the path thou Best way is to fetch the source and test it your self -D
Hide
Permalink
Barrie Treloar added a comment -

Spaces in the path?

The issue is that in a reactor build the <files> section is resolving path names to be parent project relative instead of module relative.

Show
Barrie Treloar added a comment - Spaces in the path? The issue is that in a reactor build the <files> section is resolving path names to be parent project relative instead of module relative.
Hide
Permalink
Dan Tran added a comment -

sorry about the quick judgement, i thought you have spaces in your parent directory name.

does ASSEMBLY-100 fixes your issues?

Show
Dan Tran added a comment - sorry about the quick judgement, i thought you have spaces in your parent directory name. does ASSEMBLY-100 fixes your issues?
Hide
Permalink
Barrie Treloar added a comment -

Yes, except that outputDirectory directory of

  • empty
  • /

causes the file to not be added to the archive, but no warning messages.

Specifying an outputDirectory of say "docs" works fine.

I'll write some unit tests and submit a patch if needed.

Show
Barrie Treloar added a comment - Yes, except that outputDirectory directory of empty / causes the file to not be added to the archive, but no warning messages. Specifying an outputDirectory of say "docs" works fine. I'll write some unit tests and submit a patch if needed.
Hide
Permalink
Barrie Treloar added a comment -

Interestingly, it works correctly for dir format.

And I notice for both a slash and an empty outputDirectory there is an unnamed subdirectory in the archive that contains the file (I didnt notice this before)

Show
Barrie Treloar added a comment - Interestingly, it works correctly for dir format. And I notice for both a slash and an empty outputDirectory there is an unnamed subdirectory in the archive that contains the file (I didnt notice this before)
Hide
Permalink
Barrie Treloar added a comment -

Unit test with patch to fix the issue that an assembly with includeBaseDirectory set to false fails if the outputDirectory was empty or slash.

Removal of eclipse warnings (deleting of unused variables and import cleanups)
Cleanup of some files to conform to code format as per Maven web site.

Show
Barrie Treloar added a comment - Unit test with patch to fix the issue that an assembly with includeBaseDirectory set to false fails if the outputDirectory was empty or slash. Removal of eclipse warnings (deleting of unused variables and import cleanups) Cleanup of some files to conform to code format as per Maven web site.
Hide
Permalink
Barrie Treloar added a comment -

It appears that using the Eclipse Team -> Create Patch command sucks.
It doesn't create unified diffs very well. At least the GNU windows patch 2.5.8.6 doesn't like them.

I will recreate using svn diff.

Show
Barrie Treloar added a comment - It appears that using the Eclipse Team -> Create Patch command sucks. It doesn't create unified diffs very well. At least the GNU windows patch 2.5.8.6 doesn't like them. I will recreate using svn diff.
Hide
Permalink
Barrie Treloar added a comment -

You need to use patch -p3 to apply the patches.

Show
Barrie Treloar added a comment - You need to use patch -p3 to apply the patches.
Hide
Permalink
Barrie Treloar added a comment -

New patch file working with the latest trunk code base that has created unit tests and integration tests done by John Casey.

Show
Barrie Treloar added a comment - New patch file working with the latest trunk code base that has created unit tests and integration tests done by John Casey.
Hide
Permalink
Barrie Treloar added a comment -

(patch included another patch which is now removed)

Show
Barrie Treloar added a comment - (patch included another patch which is now removed)
Hide
Permalink
Barrie Treloar added a comment -

New patch based on r471978 which does not exhibit the defect.
So the patch only includes test cases for regression purposes.

Show
Barrie Treloar added a comment - New patch based on r471978 which does not exhibit the defect. So the patch only includes test cases for regression purposes.
Hide
Permalink
Kenney Westerhof added a comment -

with the latest HEAD of the assembly plugin, this problem cannot be reproduced. I recognize that it indeed
was a problem, that why it's not 'closed - cannot reproduce'.

Committed the JUnit tests patch (with attribution) in revision 489633.
(Minor change: removed the unused imports).

Show
Kenney Westerhof added a comment - with the latest HEAD of the assembly plugin, this problem cannot be reproduced. I recognize that it indeed was a problem, that why it's not 'closed - cannot reproduce'. Committed the JUnit tests patch (with attribution) in revision 489633. (Minor change: removed the unused imports).

People

  • Assignee:
    Kenney Westerhof
    Reporter:
    Barrie Treloar
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: