no weaving in phase "test-compile" after upgrade from 1.2 to 1.3

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Critical Critical
  • Resolution: Unresolved
  • Affects Version/s: 1.3
  • Fix Version/s: None
  • Labels:
    None
  • Environment:
    MacOS 10.6.5
  • Testcase included:
    yes

Description

After upgrading from 1.2 to 1.3 our Maven builds failed. It seems that 'mvn test-compile' fails because the aspects are not weaved to the test classes.

I stripped down the problem to a simple demo project which is attached (demo.zip). If you switch the aspectj-maven-plugin to version 1.2 you will see that 'mvn test-compile' will work. With 1.3 you will get a compiler error.

Issue Links

relates to

Improvement - An improvement or enhancement to an existing feature or task. MASPECTJ-13 Change compile task to run after project classess compilation.

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Robert Scholte added a comment -

Problem is caused by MASPECTJ-13 : rev. 10439.
By binding it to the next phase the maven-compiler-plugin:2.3.2:testCompile is executed before aspectj-maven-plugin:1.4-SNAPSHOT:test-compile which causes the problem.
But when reverting it, something else happens:
aspectj-maven-plugin:1.4-SNAPSHOT:test-compile is executed before maven-resources-plugin:2.4.3:testResources and that's not the order as expected.
So this will require some more investigation.

Show
Robert Scholte added a comment - Problem is caused by MASPECTJ-13 : rev. 10439. By binding it to the next phase the maven-compiler-plugin:2.3.2:testCompile is executed before aspectj-maven-plugin:1.4-SNAPSHOT:test-compile which causes the problem. But when reverting it, something else happens: aspectj-maven-plugin:1.4-SNAPSHOT:test-compile is executed before maven-resources-plugin:2.4.3:testResources and that's not the order as expected. So this will require some more investigation.
Hide
Permalink
Oliver Boehm added a comment -

As a workaround (as discussed on http://stackoverflow.com/questions/2610633/maven-compile-aspectj-project-containing-java-1-6-source) I bound the AspectJ plugin to the process-sources phase:

<execution>
<phase>process-sources</phase>
<goals>
<goal>compile</goal>
<goal>test-compile</goal>
</goals>
</execution>

With this workaround I succeed to use the actual aspectj-maven-plugin 1.4

Show
Oliver Boehm added a comment - As a workaround (as discussed on http://stackoverflow.com/questions/2610633/maven-compile-aspectj-project-containing-java-1-6-source) I bound the AspectJ plugin to the process-sources phase: <execution> <phase>process-sources</phase> <goals> <goal>compile</goal> <goal>test-compile</goal> </goals> </execution> With this workaround I succeed to use the actual aspectj-maven-plugin 1.4

People

  • Assignee:
    Unassigned
    Reporter:
    Oliver Boehm
Vote (1)
Watch (1)

Dates

  • Created:
    Updated: