Mojo AspectJ Plugin

After Maven has run/compiled the class files based on source code under main/java exists under target/classes as well as target/test-classes

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: None
  • Labels:
    None
  • Environment:
    all
  • Number of attachments :
    0

Description

It looks as if the plugin compiles main/java under the compile:compile goal
and places the resulting class files under target/classes. Then under the
compile:testCompile goal it compiles main/java (again) as well test/java and
places the resulting class files under target/test-classes!

Issue Links

duplicates

Bug - A problem which impairs or prevents the functions of the product. MASPECTJ-23 Strange problem with aspectj plugin swapping main and test classes and resources

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
kaare kaare added a comment -

Ok.. here is what I am going to do:
adding a switch to the test-compile mojo to indicate wheter to weave main classes or not. like e.g

<configuration>
<weaveMainClasses>false</weaveMainClasses>
</configuration>

To make shure I do not brake builds made before this change I set the weaveMainClasses default to true.
The reporter of this issue (Jimisola Laursen) argued that this was kind of a strange default behaviour, and I tend to agree. So WHYT, should I set the default to false even if this could potentially ruin builds, or should I set it to false even if that is not a sensible default ?

Show
kaare kaare added a comment - Ok.. here is what I am going to do: adding a switch to the test-compile mojo to indicate wheter to weave main classes or not. like e.g <configuration> <weaveMainClasses>false</weaveMainClasses> </configuration> To make shure I do not brake builds made before this change I set the weaveMainClasses default to true. The reporter of this issue (Jimisola Laursen) argued that this was kind of a strange default behaviour, and I tend to agree. So WHYT, should I set the default to false even if this could potentially ruin builds, or should I set it to false even if that is not a sensible default ?
Hide
Permalink
kaare kaare added a comment -

ok.. added but renamed config element to weaveMainSourceFolder

Show
kaare kaare added a comment - ok.. added but renamed config element to weaveMainSourceFolder
Hide
Permalink
Howard M. Lewis Ship added a comment -

I'm really anxious for this fix. Is it available as a snapshot anywhere?

Show
Howard M. Lewis Ship added a comment - I'm really anxious for this fix. Is it available as a snapshot anywhere?
Hide
Permalink
kaare kaare added a comment -

Same problem

Show
kaare kaare added a comment - Same problem
Hide
Permalink
kaare kaare added a comment -

There is a new 1.0-beta-2-SNAPSHOT out there with the bugfix for this issue and MOJO-475.

Also I decided since I added the main target dir as aspect path. I no longer need to have weaveMainSourceFolder with default true, so now the default is false (which is the most natural anyways). Please let me know if you get any problems

Show
kaare kaare added a comment - There is a new 1.0-beta-2-SNAPSHOT out there with the bugfix for this issue and MOJO-475. Also I decided since I added the main target dir as aspect path. I no longer need to have weaveMainSourceFolder with default true, so now the default is false (which is the most natural anyways). Please let me know if you get any problems
Hide
Permalink
Howard M. Lewis Ship added a comment -

Thanks ... don't see where the 1.0-beta-2-SNAPSHOT is, however. Don't see it here: http://snapshots.maven.codehaus.org/maven2/org/codehaus/mojo/aspectj-maven-plugin/1.0-SNAPSHOT/

Show
Howard M. Lewis Ship added a comment - Thanks ... don't see where the 1.0-beta-2-SNAPSHOT is, however. Don't see it here: http://snapshots.maven.codehaus.org/maven2/org/codehaus/mojo/aspectj-maven-plugin/1.0-SNAPSHOT/
Hide
Permalink
Nick Veys added a comment -

Built 1.0-beta-2-SNAPSHOT from head this morning, been running it in our build today and it's working great, no more source/test pollution and a nice side effect it also seems to fix MCOBERTURA-41.

Show
Nick Veys added a comment - Built 1.0-beta-2-SNAPSHOT from head this morning, been running it in our build today and it's working great, no more source/test pollution and a nice side effect it also seems to fix MCOBERTURA-41 .
Hide
Permalink
kaare kaare added a comment -

Fixed in 1.0-beta-2

Show
kaare kaare added a comment - Fixed in 1.0-beta-2
Hide
Permalink
Jimisola Laursen added a comment -

Kaare, would you mind changing the "fix version(s)" from "none" to 1.0 or at least a version other than none?

Show
Jimisola Laursen added a comment - Kaare, would you mind changing the "fix version(s)" from "none" to 1.0 or at least a version other than none?

People

  • Assignee:
    kaare kaare
    Reporter:
    kaare kaare
Vote (2)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: