Mojo AppAssembler Plugin

Upgrade JSW DeltaPack from 3.2.3 to 3.3.6

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: 1.0
  • Fix Version/s: None
  • Labels:
    None
  • Patch Submitted:
    Yes
  • Number of attachments :
    1

Description

The current version of the DeltaPack used by the AppAssembler plugin does not support 64-bit Mac OSX. The attached patch should fix this by upgrading the DeltaPack to the latest version.

Issue Links

is superceded by

Improvement - An improvement or enhancement to an existing feature or task. MAPPASM-124 Upgrade JSW delta pack

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.

Improvement - An improvement or enhancement to an existing feature or task. MAPPASM-104 Upgrade to tanukisoft wrapper version 3.4.1 and include mac osx 64bit support

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Brett Porter added a comment -

we can't do this so easily:

  • there is no wrapper delta pack for recent versions
  • the license after 3.2.3 changed to GPL which may affect some users if set as a default

There's a few alternatives here:

  • add the extra configuration as you've done and make it possible to add new packs from more recent versions if desired
  • specifically for 64-bit mac os x, it may be possible to recompile the 3.2.3 sources with new flags to produce this binary? Not sure if it required additional changes.
Show
Brett Porter added a comment - we can't do this so easily: there is no wrapper delta pack for recent versions the license after 3.2.3 changed to GPL which may affect some users if set as a default There's a few alternatives here: add the extra configuration as you've done and make it possible to add new packs from more recent versions if desired specifically for 64-bit mac os x, it may be possible to recompile the 3.2.3 sources with new flags to produce this binary? Not sure if it required additional changes.
Hide
Permalink
Mads Mohr Christensen added a comment -

I don't really understand what you mean "there is no wrapper delta pack for recent versions", could you please explain that?

Show
Mads Mohr Christensen added a comment - I don't really understand what you mean "there is no wrapper delta pack for recent versions", could you please explain that?
Hide
Permalink
Mads Mohr Christensen added a comment -

It was this error message that triggered me to update JSW:

wrapper | --> Wrapper Started as Console
wrapper | Launching a JVM...
jvm 1 | Wrapper (Version 3.2.3) http://wrapper.tanukisoftware.org
jvm 1 | Copyright 1999-2006 Tanuki Software, Inc. All Rights Reserved.
jvm 1 |
jvm 1 |
jvm 1 | WARNING - Unable to load the Wrapper's native library because none of the
jvm 1 | following files:
jvm 1 | libwrapper-macosx-x86-64.jnilib
jvm 1 | libwrapper-macosx-universal-64.jnilib
jvm 1 | libwrapper.jnilib
jvm 1 | could be located on the following java.library.path:
jvm 1 | /project/lib
jvm 1 | Please see the documentation for the wrapper.java.library.path
jvm 1 | configuration property.
jvm 1 | System signals will not be handled correctly.

Only the 32-bit version exists in bin and lib (bin/wrapper-macosx-universal-32 and lib/libwrapper-macosx-universal-32.jnilib)

Tested on a 64-bit macbook.

Show
Mads Mohr Christensen added a comment - It was this error message that triggered me to update JSW: wrapper | --> Wrapper Started as Console wrapper | Launching a JVM... jvm 1 | Wrapper (Version 3.2.3) http://wrapper.tanukisoftware.org jvm 1 | Copyright 1999-2006 Tanuki Software, Inc. All Rights Reserved. jvm 1 | jvm 1 | jvm 1 | WARNING - Unable to load the Wrapper's native library because none of the jvm 1 | following files: jvm 1 | libwrapper-macosx-x86-64.jnilib jvm 1 | libwrapper-macosx-universal-64.jnilib jvm 1 | libwrapper.jnilib jvm 1 | could be located on the following java.library.path: jvm 1 | /project/lib jvm 1 | Please see the documentation for the wrapper.java.library.path jvm 1 | configuration property. jvm 1 | System signals will not be handled correctly. Only the 32-bit version exists in bin and lib (bin/wrapper-macosx-universal-32 and lib/libwrapper-macosx-universal-32.jnilib) Tested on a 64-bit macbook.
Hide
Permalink
Brett Porter added a comment -

JSW has not released a delta pack in the format we use since 3.2.3 as far as I understand, so it will need to change how the platform scripts are obtained.

As for the error - I use a 64-bit macbook without issues. Did you upgrade to snow leopard?

Show
Brett Porter added a comment - JSW has not released a delta pack in the format we use since 3.2.3 as far as I understand, so it will need to change how the platform scripts are obtained. As for the error - I use a 64-bit macbook without issues. Did you upgrade to snow leopard?
Hide
Permalink
Mads Mohr Christensen added a comment -

There is a download link for the 3.3.6 DeltaPack on the bottom of this page: http://wrapper.tanukisoftware.org/doc/english/download.jsp
The only thing I did, apart from the minor tweaks in my patch, was to install the tarball in my local repository in order to use it.

The only thing that might prevent applying this patch are license issues. But if 1.1 are release then one could still use 1.0 if forced to by the choice of license?

I'm still running 10.5.8 with this java version:

java version "1.6.0_13"
Java(TM) SE Runtime Environment (build 1.6.0_13-b03-211)
Java HotSpot(TM) 64-Bit Server VM (build 11.3-b02-83, mixed mode)

Show
Mads Mohr Christensen added a comment - There is a download link for the 3.3.6 DeltaPack on the bottom of this page: http://wrapper.tanukisoftware.org/doc/english/download.jsp The only thing I did, apart from the minor tweaks in my patch, was to install the tarball in my local repository in order to use it. The only thing that might prevent applying this patch are license issues. But if 1.1 are release then one could still use 1.0 if forced to by the choice of license? I'm still running 10.5.8 with this java version: java version "1.6.0_13" Java(TM) SE Runtime Environment (build 1.6.0_13-b03-211) Java HotSpot(TM) 64-Bit Server VM (build 11.3-b02-83, mixed mode)
Hide
Permalink
Brett Porter added a comment -

ok, I missed that before. Thanks. Can you create a MAVENUPLOAD request for the delta pack? (Make sure to keep the same group/artifact ID and change the license from the 3.2.3 POM).

I think we can consider adding the code changes in a way that is compatible with 3.2.3, and then make it so the user chooses which version to download.

Show
Brett Porter added a comment - ok, I missed that before. Thanks. Can you create a MAVENUPLOAD request for the delta pack? (Make sure to keep the same group/artifact ID and change the license from the 3.2.3 POM). I think we can consider adding the code changes in a way that is compatible with 3.2.3, and then make it so the user chooses which version to download.
Hide
Permalink
Mads Mohr Christensen added a comment -

MAVENUPLOAD request: http://jira.codehaus.org/browse/MAVENUPLOAD-2597

Show
Mads Mohr Christensen added a comment - MAVENUPLOAD request: http://jira.codehaus.org/browse/MAVENUPLOAD-2597
Hide
Permalink
Mads Mohr Christensen added a comment -

The MAVENUPLOAD request has been completed. Do I need to do more in order to finish my patch?

Show
Mads Mohr Christensen added a comment - The MAVENUPLOAD request has been completed. Do I need to do more in order to finish my patch?
Hide
Permalink
Paul Merlin added a comment - - edited

JSW is now at 3.4.0 with delta pack available.

Show
Paul Merlin added a comment - - edited JSW is now at 3.4.0 with delta pack available.
Hide
Permalink
David J. M. Karlsen added a comment -

Now at: http://wrapper.tanukisoftware.com/doc/english/download.jsp#stable (3.5.10 for the time being).
No MAVENUPLOAD requests yet.

Show
David J. M. Karlsen added a comment - Now at: http://wrapper.tanukisoftware.com/doc/english/download.jsp#stable (3.5.10 for the time being). No MAVENUPLOAD requests yet.
Hide
Permalink
David J. M. Karlsen added a comment -

http://jira.codehaus.org/browse/MAPPASM-124 is related

Show
David J. M. Karlsen added a comment - http://jira.codehaus.org/browse/MAPPASM-124 is related
Hide
Permalink
Carlos Sanchez added a comment -

Closing as it's supeerceeded by MAPPASM-124, please check there for discussion

Show
Carlos Sanchez added a comment - Closing as it's supeerceeded by MAPPASM-124 , please check there for discussion

People

  • Assignee:
    Carlos Sanchez
    Reporter:
    Mads Mohr Christensen
Vote (1)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: