Maven Ant Tasks
  1. Maven Ant Tasks
  2. MANTTASKS-44

bootstrap of components/trunk fails with ant-1.7.0RC1

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0.6
    • Fix Version/s: 2.0.7
    • Component/s: None
    • Labels:
      None
    • Number of attachments :
      2

      Description

      Bootstrap build of components/trunk with ant-1.7.0RC1 fails.

      [javac] /home/alfred/apache/maven/components/trunk/maven-artifact-ant/src/main/java/org/apache/maven/artifact/ant/LocalRepository.java:32: getLocation() in org.apache.maven.artifact.ant.LocalRepository cannot override getLocation() in org.apache.tools.ant.ProjectComponent; attempting to use incompatible return type [javac] found : java.io.File
      [javac] required: org.apache.tools.ant.Location
      [javac] public File getLocation()
      [javac] ^

      1. MANTTASKS-44_site.diff
        1.0 kB
        Herve Boutemy
      2. MANTTASKS-44.diff
        5 kB
        Herve Boutemy

        Issue Links

          Activity

          Hide
          Brett Porter added a comment -

          this isn't a blocker. You should use Ant 1.6.5.

          We'll have to change the API since it sounds like they've expanded theirs.

          Show
          Brett Porter added a comment - this isn't a blocker. You should use Ant 1.6.5. We'll have to change the API since it sounds like they've expanded theirs.
          Hide
          Jason van Zyl added a comment -

          We only use it too bootstrap and don't care if it works with every version of Ant.

          Show
          Jason van Zyl added a comment - We only use it too bootstrap and don't care if it works with every version of Ant.
          Jason van Zyl made changes -
          Field Original Value New Value
          Status Open [ 1 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Hide
          Brett Porter added a comment -

          this is actually an incompatibility with the ant tasks, not the bootstrap

          Show
          Brett Porter added a comment - this is actually an incompatibility with the ant tasks, not the bootstrap
          Brett Porter made changes -
          Status Closed [ 6 ] Reopened [ 4 ]
          Resolution Fixed [ 1 ]
          Brett Porter made changes -
          Affects Version/s 2.1 [ 11704 ]
          Component/s Bootstrap & Build [ 11865 ]
          Key MNG-2669 MANTTASKS-44
          Complexity Intermediate
          Project Maven 2 [ 10500 ] Maven 2.x Ant Tasks [ 11533 ]
          Hide
          Herve Boutemy added a comment -

          ok, found in javadoc: "org.apache.tools.ant.ProjectComponent#getLocation() Returns the file/location where this task was defined."

          We wouldn't care if it only affected bootstrap, but this affects Maven Ant Tasks in their "normal user" usage with Ant 1.7 (though only localRepository task is affected AFAIK).

          we'l have to change "location" property in <artifact:localRepository id="local.repository" location="$

          {basedir}/target/local-repo" layout="default"/>

          proposal: <artifact:localRepository id="local.repository" root="${basedir}

          /target/local-repo" layout="default"/>

          root? dir? basedir?
          Changing code is easy, changing documentation and communication about the change will need some work, but the most important thing is to find a good target...

          WDYT?

          Show
          Herve Boutemy added a comment - ok, found in javadoc: "org.apache.tools.ant.ProjectComponent#getLocation() Returns the file/location where this task was defined." We wouldn't care if it only affected bootstrap, but this affects Maven Ant Tasks in their "normal user" usage with Ant 1.7 (though only localRepository task is affected AFAIK). we'l have to change "location" property in <artifact:localRepository id="local.repository" location="$ {basedir}/target/local-repo" layout="default"/> proposal: <artifact:localRepository id="local.repository" root="${basedir} /target/local-repo" layout="default"/> root? dir? basedir? Changing code is easy, changing documentation and communication about the change will need some work, but the most important thing is to find a good target... WDYT?
          Hide
          Herve Boutemy added a comment -

          here is a patch to rename location as path (like proposed IIRC), and another to modify the site documentation

          Show
          Herve Boutemy added a comment - here is a patch to rename location as path (like proposed IIRC), and another to modify the site documentation
          Herve Boutemy made changes -
          Attachment MANTTASKS-44_site.diff [ 27609 ]
          Attachment MANTTASKS-44.diff [ 27608 ]
          Jason van Zyl made changes -
          Assignee Jason van Zyl [ jason ]
          Jason van Zyl made changes -
          Affects Version/s 2.0.6 [ 13351 ]
          Fix Version/s 2.0.7 [ 13521 ]
          Hide
          Jason van Zyl added a comment -

          Patches applied.

          Show
          Jason van Zyl added a comment - Patches applied.
          Jason van Zyl made changes -
          Status Reopened [ 4 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Jason van Zyl made changes -
          Resolution Fixed [ 1 ]
          Status Closed [ 6 ] Reopened [ 4 ]
          Jason van Zyl made changes -
          Status Reopened [ 4 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Herve Boutemy made changes -
          Link This issue is duplicated by MANTTASKS-112 [ MANTTASKS-112 ]

            People

            • Assignee:
              Jason van Zyl
              Reporter:
              Alfred Nathaniel
            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: