Maven 2.x Ant Tasks

bootstrap of components/trunk fails with ant-1.7.0RC1

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 2.0.6
  • Fix Version/s: 2.0.7
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    2

Description

Bootstrap build of components/trunk with ant-1.7.0RC1 fails.

[javac] /home/alfred/apache/maven/components/trunk/maven-artifact-ant/src/main/java/org/apache/maven/artifact/ant/LocalRepository.java:32: getLocation() in org.apache.maven.artifact.ant.LocalRepository cannot override getLocation() in org.apache.tools.ant.ProjectComponent; attempting to use incompatible return type [javac] found : java.io.File
[javac] required: org.apache.tools.ant.Location
[javac] public File getLocation()
[javac] ^

  1. File
    MANTTASKS-44_site.diff
    27/May/07 8:57 AM
    1.0 kB
    Herve Boutemy
  2. File
    MANTTASKS-44.diff
    27/May/07 8:57 AM
    5 kB
    Herve Boutemy

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. MANTTASKS-112 does not compile against Ant 1.7

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Brett Porter added a comment -

this isn't a blocker. You should use Ant 1.6.5.

We'll have to change the API since it sounds like they've expanded theirs.

Show
Brett Porter added a comment - this isn't a blocker. You should use Ant 1.6.5. We'll have to change the API since it sounds like they've expanded theirs.
Hide
Permalink
Jason van Zyl added a comment -

We only use it too bootstrap and don't care if it works with every version of Ant.

Show
Jason van Zyl added a comment - We only use it too bootstrap and don't care if it works with every version of Ant.
Hide
Permalink
Brett Porter added a comment -

this is actually an incompatibility with the ant tasks, not the bootstrap

Show
Brett Porter added a comment - this is actually an incompatibility with the ant tasks, not the bootstrap
Hide
Permalink
Herve Boutemy added a comment -

ok, found in javadoc: "org.apache.tools.ant.ProjectComponent#getLocation() Returns the file/location where this task was defined."

We wouldn't care if it only affected bootstrap, but this affects Maven Ant Tasks in their "normal user" usage with Ant 1.7 (though only localRepository task is affected AFAIK).

we'l have to change "location" property in <artifact:localRepository id="local.repository" location="$

{basedir}/target/local-repo" layout="default"/>

proposal: <artifact:localRepository id="local.repository" root="${basedir}

/target/local-repo" layout="default"/>

root? dir? basedir?
Changing code is easy, changing documentation and communication about the change will need some work, but the most important thing is to find a good target...

WDYT?

Show
Herve Boutemy added a comment - ok, found in javadoc: "org.apache.tools.ant.ProjectComponent#getLocation() Returns the file/location where this task was defined." We wouldn't care if it only affected bootstrap, but this affects Maven Ant Tasks in their "normal user" usage with Ant 1.7 (though only localRepository task is affected AFAIK). we'l have to change "location" property in <artifact:localRepository id="local.repository" location="$ {basedir}/target/local-repo" layout="default"/> proposal: <artifact:localRepository id="local.repository" root="${basedir} /target/local-repo" layout="default"/> root? dir? basedir? Changing code is easy, changing documentation and communication about the change will need some work, but the most important thing is to find a good target... WDYT?
Hide
Permalink
Herve Boutemy added a comment -

here is a patch to rename location as path (like proposed IIRC), and another to modify the site documentation

Show
Herve Boutemy added a comment - here is a patch to rename location as path (like proposed IIRC), and another to modify the site documentation
Hide
Permalink
Jason van Zyl added a comment -

Patches applied.

Show
Jason van Zyl added a comment - Patches applied.

People

  • Assignee:
    Jason van Zyl
    Reporter:
    Alfred Nathaniel
Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: