Maven 2.x Ant Tasks

System scope not working properly in Maven Antlib

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.1.0
  • Component/s: dependencies task
  • Labels:
    None
  • Environment:
    Mac OS X
  • Number of attachments :
    1

Description

If I add the following 

<dependency>
    <groupId>javax.cache</groupId>
    <artifactId>jcache</artifactId>
    <version>not_released</version>
    <scope>system</scope>
    <!--<systemPath>${basedir}/tools/jcache.jar</systemPath>-->
    <systemPath>/Users/gluck/work/ehcache/trunk/tools/jcache.jar</systemPath>
</dependency>

When I so a run I get dropping /Users/gluck/.m2/repository/javax/cache/jcache/not_released/jcache-not_released.jar from path as it doesn't exist

    [javac] net/sf/ehcache/jcache/CacheListenerAdaptor.java added as net/sf/ehcache/jcache/CacheListenerAdaptor.class doesn't exist.
    [javac] net/sf/ehcache/jcache/Entry.java added as net/sf/ehcache/jcache/Entry.class doesn't exist.
    [javac] net/sf/ehcache/jcache/JCache.java added as net/sf/ehcache/jcache/JCache.class doesn't exist.
    [javac] net/sf/ehcache/jcache/JCacheFactory.java added as net/sf/ehcache/jcache/JCacheFactory.class doesn't exist.
    [javac] net/sf/ehcache/jcache/package.html skipped - don't know how to handle it
dropping /Users/gluck/.m2/repository/javax/cache/jcache/not_released/jcache-not_released.jar from path as it doesn't exist

It should not be looking for it there.

To reproduce just try and use the system scope and systemPath.

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. MANTTASKS-189 NPE when using scope="system"

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Improvement - An improvement or enhancement to an existing feature or task. MANTTASKS-147 Improvements to scope filtering

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Vincent Siveton added a comment -

Moved to Ant tasks

Show
Vincent Siveton added a comment - Moved to Ant tasks
Hide
Permalink
Alexander Shvets added a comment -

For "system" scope classpath is built incorrectly: it build path for atrifacts as combination of local repository path and file name

Show
Alexander Shvets added a comment - For "system" scope classpath is built incorrectly: it build path for atrifacts as combination of local repository path and file name
Hide
Permalink
Alexander Shvets added a comment -

This patch fixes the problem and has 2 unit tests. One test can be solved with this patch, another test required changes in org.apache.maven.artifact.resolver.filter.ScopeArtifactFilter file:

public class ScopeArtifactFilter
implements ArtifactFilter
{

public ScopeArtifactFilter( String scope )
{
...
else if ( DefaultArtifact.SCOPE_SYSTEM.equals( scope ) )

{ systemScope = true; providedScope = false; compileScope = false; runtimeScope = false; testScope = false; }

...
}

}

Show
Alexander Shvets added a comment - This patch fixes the problem and has 2 unit tests. One test can be solved with this patch, another test required changes in org.apache.maven.artifact.resolver.filter.ScopeArtifactFilter file: public class ScopeArtifactFilter implements ArtifactFilter { public ScopeArtifactFilter( String scope ) { ... else if ( DefaultArtifact.SCOPE_SYSTEM.equals( scope ) ) { systemScope = true; providedScope = false; compileScope = false; runtimeScope = false; testScope = false; } ... } }
Hide
Permalink
Sam Mesh added a comment -

I'd like to see ant following maven as much as possible like the following:

pom.xml
<properties>
<viewRoot>$

{basedir}/..</viewRoot>
</properties>

<dependency>
<scope>system</scope>
<systemPath>${viewRoot}/lib/lib.jar</systemPath>
</dependency>

maven-build.properties
viewRoot=${basedir}

/..

maven-build.xml
<path id="build.classpath">
<pathelement location="$

{viewRoot}

/lib/lib.jar"/>
</path>

Show
Sam Mesh added a comment - I'd like to see ant following maven as much as possible like the following: pom.xml <properties> <viewRoot>$ {basedir}/..</viewRoot> </properties> <dependency> <scope>system</scope> <systemPath>${viewRoot}/lib/lib.jar</systemPath> </dependency> maven-build.properties viewRoot=${basedir} /.. maven-build.xml <path id="build.classpath"> <pathelement location="$ {viewRoot} /lib/lib.jar"/> </path>
Hide
Permalink
Paul Gier added a comment -

Fixed in r884252.

Show
Paul Gier added a comment - Fixed in r884252 .

People

  • Assignee:
    Paul Gier
    Reporter:
    Greg Luck
Vote (4)
Watch (7)

Dates

  • Created:
    Updated:
    Resolved: