Maven 2.x Ant Tasks

Improvements to scope filtering

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 2.0.10
  • Component/s: dependencies task
  • Labels:
    None
  • Number of attachments :
    0

Description

The ant tasks currently use the standard maven artifact scope filtering. This means that setting "useScope" to "compile" actually includes the scopes "compile", "runtime", and "system". This is not intuitive to a typical ant user.

A better behaviour is for the the useScope attribute to allow a comma separated list of specific scopes to include. So for example, setting useScope to "compile, provided" would only include artifacts that have one of these two scopes set.

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. MANTTASKS-102 Provided scope doesn't filter out transitive dependencies

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Reopened - This issue was once resolved, but the resolution was deemed incorrect. From here issues are either marked assigned or resolved.

Bug - A problem which impairs or prevents the functions of the product. MANTTASKS-4 System scope not working properly in Maven Antlib

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Bug - A problem which impairs or prevents the functions of the product. MANTTASKS-124 Setting dependencies with the provided scope does not work

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Paul Gier added a comment -

Fixed in r772694

Show
Paul Gier added a comment - Fixed in r772694
Hide
Permalink
Dennis Lundberg added a comment -

I am -1 to this change as it has been implemented. This will break lots of builds, including the ones at my day job. I would be OK with it, if it was available through a configuration option that was turned off by default. Something like

singleScope="true/false"

If you are using Maven Ant Tasks together with Ant, you have to think like "Maven" when it comes to dependencies. You can't think like "Ant".

Show
Dennis Lundberg added a comment - I am -1 to this change as it has been implemented. This will break lots of builds, including the ones at my day job. I would be OK with it, if it was available through a configuration option that was turned off by default. Something like singleScope= " true / false " If you are using Maven Ant Tasks together with Ant, you have to think like "Maven" when it comes to dependencies. You can't think like "Ant".
Hide
Permalink
Paul Gier added a comment -

Ok, I will make it a separate option to have a list of individual scopes.

Show
Paul Gier added a comment - Ok, I will make it a separate option to have a list of individual scopes.
Hide
Permalink
Paul Gier added a comment -

Dennis thanks for the feedback. Please take a look at the change in r772768 and let me know if that works better for you.

Show
Paul Gier added a comment - Dennis thanks for the feedback. Please take a look at the change in r772768 and let me know if that works better for you.
Hide
Permalink
Dennis Lundberg added a comment -

Thank for that Paul.

You figured out an elegant solution that nicely handles the new feature, without breaking backwards compatibility.

I am now +1 on this.

Show
Dennis Lundberg added a comment - Thank for that Paul. You figured out an elegant solution that nicely handles the new feature, without breaking backwards compatibility. I am now +1 on this.

People

  • Assignee:
    Paul Gier
    Reporter:
    Paul Gier
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: