Details

    • Type: Task Task
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.2
    • Labels:
      None
    • Number of attachments :
      3
    1. MANTRUN-55-maven-antrun-plugin.patch
      28 kB
      Franz Allan Valencia See
    2. MANTRUN-55-maven-antrun-plugin-2.patch
      29 kB
      Franz Allan Valencia See
    3. MANTRUN-55-maven-antrun-plugin-3.patch
      7 kB
      Franz Allan Valencia See

      Activity

      Hide
      Franz Allan Valencia See added a comment -

      Good day,

      MANTRUN-55-maven-antrun-plugin.patch contains documentation regarding maven-antrun-plugin and also, allows it to pass the document check for plugins (mvn docck:plugin).

      Franz

      Show
      Franz Allan Valencia See added a comment - Good day, MANTRUN-55 -maven-antrun-plugin.patch contains documentation regarding maven-antrun-plugin and also, allows it to pass the document check for plugins (mvn docck:plugin). Franz
      Hide
      Allan Ramirez added a comment -

      Looks good to me. Just a comment in your code block in usage.html, there are so many "[...]".
      I think somehing like below is enough

      <project>
        [...]
        <build>
          <plugins>
            <plugin>
              <artifactId>maven-antrun-plugin</artifactId>
              <executions>
                <execution>
                  <phase> <!-- a lifecycle phase --> </phase>
                  <configuration>
                    <tasks>
      
                      <!--
                        Place any ant task here. You can add anything
                        you can add between <target> and </target> in a
                        build.xml.
                      -->
                      
                    </tasks>
                  </configuration>
                  <goals>
                    <goal>run</goal>
                  </goals>
                </execution>
              </executions>
            </plugin>
          </plugins>
        </build>
        [...]
      </project>
      
      Show
      Allan Ramirez added a comment - Looks good to me. Just a comment in your code block in usage.html, there are so many " [...] ". I think somehing like below is enough <project> [...] <build> <plugins> <plugin> <artifactId> maven-antrun-plugin </artifactId> <executions> <execution> <phase> <!-- a lifecycle phase --> </phase> <configuration> <tasks> <!-- Place any ant task here. You can add anything you can add between <target> and </target> in a build.xml. --> </tasks> </configuration> <goals> <goal> run </goal> </goals> </execution> </executions> </plugin> </plugins> </build> [...] </project>
      Hide
      Franz Allan Valencia See added a comment -

      Changes with MANTRUN-55-maven-antrun-plugin-2.patch from MANTRUN-55-maven-antrun-plugin.patch

      In usage.html
      Removed excess "[...]" (Reported by Allan Ramirez)

      Show
      Franz Allan Valencia See added a comment - Changes with MANTRUN-55 -maven-antrun-plugin-2.patch from MANTRUN-55 -maven-antrun-plugin.patch In usage.html Removed excess " [...] " (Reported by Allan Ramirez)
      Hide
      Allan Ramirez added a comment -

      Applied patch.. and I also deployed your site.

      http://people.apache.org/~aramirez/maven-antrun-plugin/index.html

      Thanks

      Show
      Allan Ramirez added a comment - Applied patch.. and I also deployed your site. http://people.apache.org/~aramirez/maven-antrun-plugin/index.html Thanks
      Hide
      Franz Allan Valencia See added a comment -

      Changes with MANTRUN-55-maven-antrun-plugin-3.patch

      In usage.html

      • maven.dependency.classpath (Reported by Vincent Siveton)
      • Review <<<inheritRefs>> (Reported by Vincent Siveton)
      • it seems that there is bug here (from what i can dig up in the maven user's mailing list) such that referencing maven.xxx.classpath's within the build.xml does not work. thus, i changed the example to a workaround (assigning the maven.xxx.classpath's value to an ant property). Furthermore, this page may not be needed in the future once Vincent Siventon's submits his example of using external build.xml
      • changed "maven-dependencies-plugin" to "maven-dependency-plugin"

      In FAQ.html

      • "Maven for Ant Users" is for Maven1 and it's link is wrong (Reported by Vincent Siventon)
      • thus, i removed this link
      Show
      Franz Allan Valencia See added a comment - Changes with MANTRUN-55 -maven-antrun-plugin-3.patch In usage.html maven.dependency.classpath (Reported by Vincent Siveton) Review <<<inheritRefs>> (Reported by Vincent Siveton) it seems that there is bug here (from what i can dig up in the maven user's mailing list) such that referencing maven.xxx.classpath's within the build.xml does not work. thus, i changed the example to a workaround (assigning the maven.xxx.classpath's value to an ant property). Furthermore, this page may not be needed in the future once Vincent Siventon's submits his example of using external build.xml changed "maven-dependencies-plugin" to "maven-dependency-plugin" In FAQ.html "Maven for Ant Users" is for Maven1 and it's link is wrong (Reported by Vincent Siventon) thus, i removed this link
      Hide
      Allan Ramirez added a comment -

      Applied patch, and I also updated your staging site

      http://people.apache.org/~aramirez/maven-antrun-plugin/index.html

      Thanks!

      Show
      Allan Ramirez added a comment - Applied patch, and I also updated your staging site http://people.apache.org/~aramirez/maven-antrun-plugin/index.html Thanks!

        People

        • Assignee:
          Allan Ramirez
          Reporter:
          Allan Ramirez
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Due:
            Created:
            Updated:
            Resolved:

            Time Tracking

            Estimated:
            Original Estimate - 12 hours
            12h
            Remaining:
            Time Spent - 2 hours Remaining Estimate - 10 hours
            10h
            Logged:
            Time Spent - 2 hours Remaining Estimate - 10 hours
            2h