Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.1
-
Fix Version/s: 1.1
-
Labels:None
-
Testcase included:yes
-
Number of attachments :
Description
The propoerties placed not alone inside quotes are not correctly interpreted. For example :
<property name="myProp" value="OK" />
<echo message="alone in quote :"/>
<echo message="$
<echo>not alone in text ${myProp}
.</echo>
<echo message="not alone in quote $
."></echo>
<fail unless="myProp"/>
Succeed and print :
[echo] alone in quote :
[echo] OK
[echo] not alone in text OK.
[echo] not alone in quote null.
While executed directly into ant prints :
[echo] alone in quote :
[echo] OK
[echo] not alone in text OK.
[echo] not alone in quote OK.
You can find in attachment the pom.xml and the ant.xml I used.
Issue Links
- is duplicated by
-
MANTRUN-29
antrun: properties not resolved in attributes
-
In have found in the reason in the code.
When a property $
{...} is placed into an XML text, the value is not processed by the PluginParameterExpressionEvaluator.The text is thus given as is to ant, that forward it to the AntPropertyHelper provided by the antrun mojo. It works as expected.
When a property ${...}
is placed alone in an attribute, the PluginParameterExpressionEvaluator evaluate it to null, the AntTargetConverter of
the antrun plugin detect this null, and forward the original ${} to ant. It works as expected.
When a property $
{...}is placed with some text into an attribute (for example "a text $
{x}"), the PluginParameterExpressionEvaluator evaluate it to a string
containing "a text null", the AntTargetConverter of the antrun plugin forward this text to ant that doesn't detect a property. It is the bu I have found.
The solution is to not use the PluginParameterExpressionEvaluator before, but only after ant property processing (into the AntPropertyHelper).