Mojo Animal Sniffer

animal-sniffer maven plugin descends into JAR files in the build directory

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.5
  • Fix Version/s: 1.7
  • Component/s: Maven Plugin
  • Labels:
    None
  • Number of attachments :
    0

Description

to reproduce:
$ svn co -r 911542 http://svn.apache.org/repos/asf/sling/trunk sling-builder
$ cd sling-builder
$ mvn -P animal-sniffer install

In the launchpad/builder module, you'll get errors like this:
[ERROR] Undefined reference: javax/portlet/ActionRequest.getCharacterEncoding()Ljava/lang/String; in /Users/justin/Workspace/sling-builder/launchpad/builder/target/classes/resources/bundles/0/commons-fileupload-1.2.1.jar:org/apache/commons/fileupload/portlet/PortletRequestContext.class

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andreas Sewe added a comment -

I have been bitten by this, too: I have a packaging requirement that forces me to put further JARs with the artifact's JAR. The maven-dependency-plugin copies this these JARs into the project's output directory in the prepare-package phase. With the animal-sniffer-maven-plugin bound to the verify phase (which IMHO makes more sense than its default phase of process-classes) these nested JARs get accidentally checked as well.

Show
Andreas Sewe added a comment - I have been bitten by this, too: I have a packaging requirement that forces me to put further JARs with the artifact's JAR. The maven-dependency-plugin copies this these JARs into the project's output directory in the prepare-package phase. With the animal-sniffer-maven-plugin bound to the verify phase (which IMHO makes more sense than its default phase of process-classes ) these nested JARs get accidentally checked as well.
Hide
Permalink
Andreas Sewe added a comment -

Just an addendum to my last comment: This is not only a problem when the animal-sniffer-maven-plugin is bound to a phase executed after the JAR files have been copied to the build directory, but also when doing a mvn clean deploy site-deploy. While for the deploy the plugin does not see the JAR files, as they have been copied in a later phase, it sees them during the lifecycle forked by the maven-site-plugin, causing the first execution of animal-sniffer:check to succeed but the second one to fail. This is extremely irritating.

Show
Andreas Sewe added a comment - Just an addendum to my last comment: This is not only a problem when the animal-sniffer-maven-plugin is bound to a phase executed after the JAR files have been copied to the build directory, but also when doing a mvn clean deploy site-deploy . While for the deploy the plugin does not see the JAR files, as they have been copied in a later phase, it sees them during the lifecycle forked by the maven-site-plugin , causing the first execution of animal-sniffer:check to succeed but the second one to fail. This is extremely irritating.
Hide
Permalink
Stephen Connolly added a comment -

r14300

Show
Stephen Connolly added a comment - r14300

People

  • Assignee:
    Stephen Connolly
    Reporter:
    Justin Edelson
Vote (1)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: