loom

Fold loom-tools into maven-sar

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.0-beta1
  • Fix Version/s: 1.0-beta1
  • Component/s: Tools
  • Labels:
    None
  • Number of attachments :
    0

Description

Currently the only class in loom-tools is the SarTask. This could quite easily be migrated into the maven-sar plugin. The maven-sar artifact produced can be used to run ant tasks or be installed into the maven runtime. As I think it would be simpler to combine the two rather than having a 1-class jar as a dependency of the plugin I would like to merge.

However you didn't think this was a good idea last time so I assigned to you and let you decide

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mauro Talevi added a comment -

I actually was opposed to the opposite,
ie merging the plugin in a big jar with all the tools.
Defeats the point of a plugin if it bundled with things that are
not plugin related.
I do agree that the SarTask should be part of the
plugin codebase

Show
Mauro Talevi added a comment - I actually was opposed to the opposite, ie merging the plugin in a big jar with all the tools. Defeats the point of a plugin if it bundled with things that are not plugin related. I do agree that the SarTask should be part of the plugin codebase
Hide
Permalink
Mauro Talevi added a comment -

Moved the SarTask in the sar plugin itself.

Changes required for projects intending to use are:

  • Add dependency of type jar (the implicit default) and not plugin
    <dependency>
    <groupId>loom</groupId>
    <artifactId>maven-sar-plugin</artifactId>
    <version>[version]</version>
    </dependency>
  • download the plugin (once) via the command
    maven -DgroupId=loom -DartifactId=maven-sar-plugin -Dversion=[version] plugin:download
Show
Mauro Talevi added a comment - Moved the SarTask in the sar plugin itself. Changes required for projects intending to use are: Add dependency of type jar (the implicit default) and not plugin <dependency> <groupId>loom</groupId> <artifactId>maven-sar-plugin</artifactId> <version> [version] </version> </dependency> download the plugin (once) via the command maven -DgroupId=loom -DartifactId=maven-sar-plugin -Dversion= [version] plugin:download

People

  • Assignee:
    Mauro Talevi
    Reporter:
    Peter Donald
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: