Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.3
-
Fix Version/s: 2.4
-
Component/s: None
-
Labels:None
-
Testcase included:yes
-
Patch Submitted:Yes
-
Number of attachments :
Description
I have identified the following issues:
- a // comment does not properly mask a subsequent /* on the same line.
- explicitly tries not to terminate comments if */ is embedded in a string, but compilers don't behave this way.
- does not handle /*/ construct properly: recognized as javadoc but not terminated, while it is better interpreted as /[empty]*/.
I have addressed these issues + JXR-58 by reworking the comment handling code. Formerly the filters were applied
; my version of the code uses
{ ongoing-multiline, inline, begin-multiline }specifically to address the first of the issues noted above. I was unable to find any exhaustive tests for this code; please guide me if there is any further testing I can provide. I have collapsed the duplicate code in these regions as much as possible, and since this project is on maven-parent v21 I believe I was justified in replacing the StringBuffers in affected areas with StringBuilders (obviously the whole file might benefit minutely from this treatment).
Issue Links
- supercedes
-
JXR-58
Syntax highlighting broken for inline comments
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Attachment | JXR-96.patch.txt [ 59062 ] |
| Affects Version/s | 2.4 [ 17492 ] |
| Status | Open [ 1 ] | Closed [ 6 ] |
| Assignee | Lukas Theussl [ lukas ] | |
| Fix Version/s | 2.4 [ 17492 ] | |
| Resolution | Fixed [ 1 ] |