Maven JXR

Change line number anchor name pattern

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 2.2
  • Fix Version/s: None
  • Component/s: jxr
  • Labels:
    None
  • Environment:
    Site plugin 2.2
  • Number of attachments :
    1

Description

Linenumber achor anames are solely the line number but this brings problems. Then linking in APT to source code, it complains:

[WARNING] [APT Parser] Modified invalid link: '77' to '../kcc-core/xref/package/Object.html#a77'

This means that I am not able to link to lines anymore. Change the anchor name pattern to L\d+

  1. Text File
    JXR-87.patch
    16/Jul/11 2:41 PM
    0.7 kB
    Michael Osipov

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Michael Osipov added a comment -

The suspicious line is: http://svn.apache.org/viewvc/maven/jxr/tags/jxr-2.2/maven-jxr/src/main/java/org/apache/maven/jxr/JavaCodeTransform.java?view=markup#l375

Show
Michael Osipov added a comment - The suspicious line is: http://svn.apache.org/viewvc/maven/jxr/tags/jxr-2.2/maven-jxr/src/main/java/org/apache/maven/jxr/JavaCodeTransform.java?view=markup#l375
Hide
Permalink
Neeme Praks added a comment -

Your patch will break all the links out there that rely on the current format. I would suggest to include a configuration option to restore the old behavior for people that cannot update all the other systems that rely on the old format. But new format should be default as the current format is broken (see also http://stackoverflow.com/questions/7110556/is-it-valid-to-use-only-digits-as-uri-fragment-identifier)

Show
Neeme Praks added a comment - Your patch will break all the links out there that rely on the current format. I would suggest to include a configuration option to restore the old behavior for people that cannot update all the other systems that rely on the old format. But new format should be default as the current format is broken (see also http://stackoverflow.com/questions/7110556/is-it-valid-to-use-only-digits-as-uri-fragment-identifier )
Hide
Permalink
Michael Osipov added a comment -

True, but it was broken anyway. Doxia was broken too before Maven 2.2.x. That's the reason I created this patch. Btw, for those who upgrade from Maven 2.0 to 2.2 they see broken links too. So in my opinion there is little harm.

Show
Michael Osipov added a comment - True, but it was broken anyway. Doxia was broken too before Maven 2.2.x. That's the reason I created this patch. Btw, for those who upgrade from Maven 2.0 to 2.2 they see broken links too. So in my opinion there is little harm.

People

  • Assignee:
    Unassigned
    Reporter:
    Michael Osipov
Vote (0)
Watch (1)

Dates

  • Created:
    Updated: