Maven JXR

Make file encoding default to platform encoding

Details

  • Type: Wish Wish
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0
  • Fix Version/s: 2.2
  • Component/s: maven2 jxr plugin
  • Labels:
    None
  • Number of attachments :
    0

Description

According to the user poll about the default file encoding, the inputEncoding and outputEncoding should default to the platform default encoding instead of Latin-1. Since that would be a breaking change it is left to users to vote for this issue if they feelt it's worth to have it like that.

If the change is made, we should have the plugin output a warning when using the platform encoding.

Issue Links

is related to

Wish - General wishlist item MJAVADOC-185 Revert MJAVADOC-165 and default to platform encoding

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
relates to

Wish - General wishlist item MSITE-326 Make file encoding default to platform encoding

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.
supercedes

Improvement - An improvement or enhancement to an existing feature or task. JXR-60 use ${project.build.sourceEncoding} as default value for "inputEncoding" parameter

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Brian Fox added a comment -

What encoding is the compiler using? It seems to me that this should match the compiler as it is also primarily reading the source. My bet without looking is that the compiler is using platform encoding by default.

Show
Brian Fox added a comment - What encoding is the compiler using? It seems to me that this should match the compiler as it is also primarily reading the source. My bet without looking is that the compiler is using platform encoding by default.
Hide
Permalink
Benjamin Bentmann added a comment -

You bet right, the Compiler Plugin is using platform encoding by default. I requested to change this in MCOMPILER-63 but have already re-opened the issue to revert the changes on trunk (if SVN ever comes back...).

Show
Benjamin Bentmann added a comment - You bet right, the Compiler Plugin is using platform encoding by default. I requested to change this in MCOMPILER-63 but have already re-opened the issue to revert the changes on trunk (if SVN ever comes back...).
Hide
Permalink
Herve Boutemy added a comment -

done in r657630 for trunk and r657631 for sandbox

Show
Herve Boutemy added a comment - done in r657630 for trunk and r657631 for sandbox

People

  • Assignee:
    Herve Boutemy
    Reporter:
    Benjamin Bentmann
Vote (9)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: