Maven JXR
  1. Maven JXR
  2. JXR-59

speed up AbstractJxrReport.hasSources()

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.3
    • Component/s: maven2 jxr plugin
    • Labels:
      None
    • Number of attachments :
      0

      Description

      The method AbstractJxrReport.hasSources( File dir ) spends a lot of time scanning .svn directories when I do my build.

      If you replace the line,

      else if ( currentFile.isDirectory() )

      with the lines

      else if ( currentFile.isDirectory()  &&
                   Character.isJavaIdentifierStart(currentFile.getName().charAt(0))
      )

      You will speed this up.

      If the first character in the directory is not a valid java identifier start, then the directory cannot contain java code. '.' is not a valid java identifier start, so .svn directories are ignored when scanning for sources.

        Activity

        Hide
        Herve Boutemy added a comment -

        fixed in r1137460
        thank you

        Show
        Herve Boutemy added a comment - fixed in r1137460 thank you

          People

          • Assignee:
            Herve Boutemy
            Reporter:
            Sean Bridges
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: