JRuby

Add rake and rspec to standard JRuby distribution for 1.0

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: JRuby 1.0.0RC3
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

Rake is an absolute standard for almost all Ruby development. RSpec is fast becoming the standard way to specify and test applications. We believe both should be included in the base install of JRuby, and so we should add them into our repository.

Rake is at version 0.7.3 and RSpec is at version 1.0.0. RSpec passes all its specs now. It would be good to make an effort to get Rake's tests closer to 100% as well.

I'm on the fence as to whether we should commit RSpec and Rake in SVN, or just have them install as part of "dist" and "test" targets. I don't feel right about committing packages in the local repo to SVN.

Activity

Hide
Aslak Hellesoy added a comment -

First: Thanks a ton for deciding to include RSpec in JRuby. It's going to be interesting to see how people will use RSpec with Java objects.
Ola showed me some minor quirks in RSpec's own specs that were a hindrance for 100% green on JRuby. I've just committed fixes for all of these, so hopefully everything is ok now. Those fixes will be in 1.0.1. Give us a heads up and we can release it before you push out 1.0.0.

I agree that it's a little dirty to check in copies of Rake/RSpec source into your svn. Perhaps a pragmatic middle ground is to just check in the gem files? Or was that what you meant?

Show
Aslak Hellesoy added a comment - First: Thanks a ton for deciding to include RSpec in JRuby. It's going to be interesting to see how people will use RSpec with Java objects. Ola showed me some minor quirks in RSpec's own specs that were a hindrance for 100% green on JRuby. I've just committed fixes for all of these, so hopefully everything is ok now. Those fixes will be in 1.0.1. Give us a heads up and we can release it before you push out 1.0.0. I agree that it's a little dirty to check in copies of Rake/RSpec source into your svn. Perhaps a pragmatic middle ground is to just check in the gem files? Or was that what you meant?
Hide
Albert Strasheim added a comment -

I've seen that quite a few of the Jakarta projects have their Ant builds set up to download dependent JARs from somewhere (usually a Maven repo). How about a little Ant task that calls JRuby to call something in the rubygems module to fetch the Rake and RSpec gems as part of the build? Probably overkill.

Show
Albert Strasheim added a comment - I've seen that quite a few of the Jakarta projects have their Ant builds set up to download dependent JARs from somewhere (usually a Maven repo). How about a little Ant task that calls JRuby to call something in the rubygems module to fetch the Rake and RSpec gems as part of the build? Probably overkill.
Hide
Charles Oliver Nutter added a comment -

FYI:

  • rspec is running 100% green now, and is part of our CI server
  • Nick already added code into the build to install rspec gem as needed for testing and dist. Run ant target "install-gems"
  • I've pulled in Rubinius's specs and added the 100% green ones to a "test-spec" target in ant. It runs once with the JIT at threshold zero and once in pure interpreted mode.
Show
Charles Oliver Nutter added a comment - FYI:
  • rspec is running 100% green now, and is part of our CI server
  • Nick already added code into the build to install rspec gem as needed for testing and dist. Run ant target "install-gems"
  • I've pulled in Rubinius's specs and added the 100% green ones to a "test-spec" target in ant. It runs once with the JIT at threshold zero and once in pure interpreted mode.
Hide
Nick Sieger added a comment -

All set to go for 1.0. The only artifact that won't contain the gems is the complete jar that's generated by the ant build, but since we don't distribute that, it shouldn't matter.

Show
Nick Sieger added a comment - All set to go for 1.0. The only artifact that won't contain the gems is the complete jar that's generated by the ant build, but since we don't distribute that, it shouldn't matter.
Hide
Damon Rand added a comment -

Is this issue actually complete? When I download jruby-bin-1.0.zip, unzip and type "rake" at the command line on Windows it says "'rake' is not recognized as an internal or external command".. I expected to see rake.bat in the /bin/ folder???

Damon.

Show
Damon Rand added a comment - Is this issue actually complete? When I download jruby-bin-1.0.zip, unzip and type "rake" at the command line on Windows it says "'rake' is not recognized as an internal or external command".. I expected to see rake.bat in the /bin/ folder??? Damon.
Hide
Nick Sieger added a comment -

We're not creating .bat stubs for installed gems. Instead, please get used to doing

jruby -S rake

If you think we should be creating .bat stubs, please create a new issue for that.

Show
Nick Sieger added a comment - We're not creating .bat stubs for installed gems. Instead, please get used to doing
jruby -S rake
If you think we should be creating .bat stubs, please create a new issue for that.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: