[#JRUBY-934] Unsupported NKF module

JRuby

Unsupported NKF module

Created: 13/May/07 01:29 AM Updated: 22/May/07 05:51 PM

Component/s:

Core Classes/Modules

Affects Version/s:

JRuby 1.0.0RC1

Fix Version/s:

JRuby 1.0.0RC2

Time Tracking:

Not Specified

File Attachments:

nkf.patch (16 kB)
2.

nkf2.patch (16 kB)

Testcase included:

yes

Description

« Hide

Hi,

I implemented the NKF module, which is very popular and important in japan.
I really hope this patch will be applied.

NOTE:

It doesn't have 100% compatibility with MRI. Currently about 50% functions are supported.
The Kconv works fine.
TODO: MIME encoding/decoding is not implemented yet. I'll continue to work on it.

All

Comments

Work Log

Change History

Sort Order:

[ Permalink | « Hide ]

Thomas E Enebo added a comment - 14/May/07 12:47 PM

We would love to land this patch. We still support Java 1.4 as a platform and Java 5 enum support needs to be converted into something Java 1.4 friendly. Could you make that change and resubmit please? We are very happy someone is tackling these libraries as we do not have the expertise to work on them.

[ Permalink | « Hide ]

Koichiro Ohba added a comment - 14/May/07 06:32 PM

I see, just a moment

[ Permalink | « Hide ]

Koichiro Ohba added a comment - 14/May/07 09:04 PM

I rewrote it for Java 1.4. Please check it.

thanks,

[ Permalink | « Hide ]

Thomas E Enebo added a comment - 15/May/07 07:16 PM

Fixed in commit 3659 (by Koichiro Ohba)

[ Permalink | « Hide ]

Koichiro Ohba added a comment - 16/May/07 11:39 AM

I'm really happy! thx!

[ Permalink | « Hide ]

Thomas E Enebo added a comment - 16/May/07 11:58 AM

On bamboo (our continuous integration software) we are seeing an error in test_nkf. This is strange since it works on my machine (and yours). On solaris, it is not passing:
http://jruby.thresher.com/browse/JRUBY-MVN-382

I will remove the test and open a new Jira on this issue...