JRuby

Unsupported NKF module

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: JRuby 1.0.0RC1
  • Fix Version/s: JRuby 1.0.0RC2
  • Component/s: Core Classes/Modules
  • Labels:
    None
  • Testcase included:
    yes
  • Number of attachments :
    2

Description

Hi,

I implemented the NKF module, which is very popular and important in japan.
I really hope this patch will be applied.

NOTE:

  • It doesn't have 100% compatibility with MRI. Currently about 50% functions are supported.
  • The Kconv works fine.
  • TODO: MIME encoding/decoding is not implemented yet. I'll continue to work on it.

Attachments

  1. Text File
    nkf.patch
    13/May/07 1:29 AM
    16 kB
    Koichiro Ohba
  2. Text File
    nkf2.patch
    14/May/07 9:04 PM
    16 kB
    Koichiro Ohba

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Thomas E Enebo added a comment -

We would love to land this patch. We still support Java 1.4 as a platform and Java 5 enum support needs to be converted into something Java 1.4 friendly. Could you make that change and resubmit please? We are very happy someone is tackling these libraries as we do not have the expertise to work on them.

Show
Thomas E Enebo added a comment - We would love to land this patch. We still support Java 1.4 as a platform and Java 5 enum support needs to be converted into something Java 1.4 friendly. Could you make that change and resubmit please? We are very happy someone is tackling these libraries as we do not have the expertise to work on them.
Hide
Permalink
Koichiro Ohba added a comment -

I see, just a moment

Show
Koichiro Ohba added a comment - I see, just a moment
Hide
Permalink
Koichiro Ohba added a comment -

I rewrote it for Java 1.4. Please check it.

thanks,

Show
Koichiro Ohba added a comment - I rewrote it for Java 1.4. Please check it. thanks,
Hide
Permalink
Thomas E Enebo added a comment -

Fixed in commit 3659 (by Koichiro Ohba)

Show
Thomas E Enebo added a comment - Fixed in commit 3659 (by Koichiro Ohba)
Hide
Permalink
Koichiro Ohba added a comment -

I'm really happy! thx!

Show
Koichiro Ohba added a comment - I'm really happy! thx!
Hide
Permalink
Thomas E Enebo added a comment -

On bamboo (our continuous integration software) we are seeing an error in test_nkf. This is strange since it works on my machine (and yours). On solaris, it is not passing:
http://jruby.thresher.com/browse/JRUBY-MVN-382

I will remove the test and open a new Jira on this issue...

Show
Thomas E Enebo added a comment - On bamboo (our continuous integration software) we are seeing an error in test_nkf. This is strange since it works on my machine (and yours). On solaris, it is not passing: http://jruby.thresher.com/browse/JRUBY-MVN-382 I will remove the test and open a new Jira on this issue...

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.